starred/act

Fork 0

mirror of https://github.com/nektos/act.git synced 2026-04-26 01:15:51 +03:00

[GH-ISSUE #1022] Issue: parse all container/services options #597

New issue

Open

opened 2026-03-01 21:44:49 +03:00 by kerem · 7 comments

kerem commented

2026-03-01 21:44:49 +03:00

Owner

Originally created by @catthehacker on GitHub (Mar 1, 2022).
Original GitHub issue: https://github.com/nektos/act/issues/1022

on: push

jobs:
  docker-container:
    runs-on: ubuntu-latest
    container:
      image: alpine
      options: --it --rm
    steps:
      - uses: actions/checkout@v2

Originally created by @catthehacker on GitHub (Mar 1, 2022). Original GitHub issue: https://github.com/nektos/act/issues/1022 ``` on: push jobs: docker-container: runs-on: ubuntu-latest container: image: alpine options: --it --rm steps: - uses: actions/checkout@v2 ```

kerem added the

kind/bug

stale-exempt

labels

2026-03-01 21:44:49 +03:00

kerem commented

2026-03-01 21:44:50 +03:00

Author

Owner

@bhaveshprajapat commented on GitHub (Oct 3, 2022):

bump

@bhaveshprajapat commented on GitHub (Oct 3, 2022): bump

kerem commented

2026-03-01 21:44:50 +03:00

Author

Owner

@KnisterPeter commented on GitHub (Oct 3, 2022):

@bhaveshprajapat Feel free to create a pull request 😉

@KnisterPeter commented on GitHub (Oct 3, 2022): @bhaveshprajapat Feel free to create a pull request 😉

kerem commented

2026-03-01 21:44:50 +03:00

Author

Owner

@KnisterPeter commented on GitHub (Oct 7, 2022):

@cplee @alex-savchuk This change contains a major issue. The workflow below does not return the hostname of the host but some other invalid fqdn.
I'm not sure why this happens, but it is a side-effect of this PR. Reverting it does restore the previous behavior.

name: test
on: push

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - run: hostname -f

@KnisterPeter commented on GitHub (Oct 7, 2022): @cplee @alex-savchuk This change contains a major issue. The workflow below does not return the hostname of the host but some other invalid fqdn. I'm not sure why this happens, but it is a side-effect of this PR. Reverting it does restore the previous behavior. ```yaml name: test on: push jobs: test: runs-on: ubuntu-latest steps: - run: hostname -f ```

kerem commented

2026-03-01 21:44:51 +03:00

Author

Owner

@KnisterPeter commented on GitHub (Oct 7, 2022):

According to the docs, if no container is set, the job should run on the host.
This was imitated with act until this fix was applied.
We should restore the default behavior unless there is a container definition on a job.

@KnisterPeter commented on GitHub (Oct 7, 2022): According to the [docs](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontainer), if no container is set, the job should run on the host. This was imitated with act until this fix was applied. We should restore the default behavior unless there is a `container` definition on a job.

kerem commented

2026-03-01 21:44:51 +03:00

Author

Owner

@alex-savchuk commented on GitHub (Oct 7, 2022):

Checking it.

@alex-savchuk commented on GitHub (Oct 7, 2022): Checking it.

kerem commented

2026-03-01 21:44:51 +03:00

Author

Owner

@alex-savchuk commented on GitHub (Oct 7, 2022):

@KnisterPeter
Could you please provide output for previous output of hostname -f and new one?
I checked and see "docker-desktop" for both cases :(

@alex-savchuk commented on GitHub (Oct 7, 2022): @KnisterPeter Could you please provide output for previous output of ```hostname -f``` and new one? I checked and see "docker-desktop" for both cases :(

kerem commented

2026-03-01 21:44:51 +03:00

Author

Owner

@KnisterPeter commented on GitHub (Oct 10, 2022):

The 'previous' output was the output of the host machine as act was used to start the docker container in network mode host. Now with your fix it is started with the default network mode.
As you are parsing an empty string into docker options (using the cli tool) the output are all the docker defaults. Then you merge that into (and over) the act defaults.
I've already build a fix for this: https://github.com/nektos/act/pull/1375

Please test if your change did not break with that. 😃

@KnisterPeter commented on GitHub (Oct 10, 2022): The 'previous' output was the output of the host machine as act was used to start the docker container in network mode `host`. Now with your fix it is started with the default network mode. As you are parsing an empty string into docker options (using the cli tool) the output are all the docker defaults. Then you merge that into (and over) the act defaults. I've already build a fix for this: https://github.com/nektos/act/pull/1375 Please test if your change did not break with that. :smiley:

kerem referenced this issue

2026-03-01 21:51:34 +03:00

[PR #637] [MERGED] Fixes Issue #597 #1532

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#597

No description provided.

Rows
Columns