[PR #151] [MERGED] SOA for authoritative NXDOMAIN response should be in the Authoritative section #327

New issue

Closed

opened 2026-03-13 16:17:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:17:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/151
Author: @cure
Created: 2/6/2019
Status: ✅ Merged
Merged: 2/7/2019
Merged by: @joohoi

Base: master ← Head: master

📝 Commits (1)

aa44cc4 When appending the SOA for authoritative NXDOMAIN responses, it needs to go in

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 dns.go (+1 -1)
📝 dns_test.go (+4 -4)

📄 Description

When appending the SOA for authoritative NXDOMAIN responses, it needs to go in the Authoritative section, not the Answer section.

This fixes acme-dns validation for the lego Let's Encrypt client.

This issue was identified in lego issue 707 and almost fixed in acme-dns issue 127.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/151 **Author:** [@cure](https://github.com/cure) **Created:** 2/6/2019 **Status:** ✅ Merged **Merged:** 2/7/2019 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`aa44cc4`](https://github.com/acme-dns/acme-dns/commit/aa44cc4481b5c768060e8eb405def4b588ca32f3) When appending the SOA for authoritative NXDOMAIN responses, it needs to go in ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `dns.go` (+1 -1) 📝 `dns_test.go` (+4 -4) </details> ### 📄 Description When appending the SOA for authoritative NXDOMAIN responses, it needs to go in the Authoritative section, not the Answer section. This fixes acme-dns validation for the lego Let's Encrypt client. This issue was identified in [lego issue 707](https://github.com/xenolf/lego/issues/707) and almost fixed in [acme-dns issue 127](https://github.com/joohoi/acme-dns/issues/127). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>