[PR #327] [MERGED] Refactoring #379

New issue

Closed

opened 2026-03-13 16:20:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:20:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/327
Author: @fritterhoff
Created: 1/1/2023
Status: ✅ Merged
Merged: 3/6/2023
Merged by: @joohoi

Base: refactoring ← Head: refactoring

📝 Commits (5)

bd30bb5 chore: enable more linters and fix linter issues
63b9b64 ci: enable linter checks on all branches and disable recurring checks
b47f341 chore: update packages
7f625a7 Revert "chore: update packages"
dd73feb chore: manually upgrade some packages

📊 Changes

22 files changed (+164 additions, -90 deletions)

View changed files

📝 .github/workflows/golangci-lint.yml (+0 -8)
➕ .golangci.yaml (+15 -0)
➕ .vscode/settings.json (+5 -0)
📝 go.mod (+19 -20)
📝 go.sum (+77 -34)
📝 main.go (+2 -2)
📝 pkg/acmedns/acmetxt.go (+2 -1)
📝 pkg/acmedns/interfaces.go (+1 -0)
📝 pkg/acmedns/util.go (+2 -1)
📝 pkg/acmedns/util_test.go (+4 -3)
📝 pkg/api/api_test.go (+2 -2)
📝 pkg/api/auth.go (+2 -1)
📝 pkg/api/challengeprovider.go (+2 -1)
📝 pkg/api/register.go (+2 -1)
📝 pkg/api/util.go (+4 -2)
📝 pkg/api/validation_test.go (+2 -1)
📝 pkg/database/db.go (+4 -2)
📝 pkg/database/db_test.go (+4 -2)
📝 pkg/nameserver/dns_test.go (+6 -4)
📝 pkg/nameserver/handler.go (+2 -1)

...and 2 more files

📄 Description

I prefer to enable some more linters ;)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/327 **Author:** [@fritterhoff](https://github.com/fritterhoff) **Created:** 1/1/2023 **Status:** ✅ Merged **Merged:** 3/6/2023 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `refactoring` ← **Head:** `refactoring` --- ### 📝 Commits (5) - [`bd30bb5`](https://github.com/acme-dns/acme-dns/commit/bd30bb5d11b82e9d764190299ebf8c0195958025) chore: enable more linters and fix linter issues - [`63b9b64`](https://github.com/acme-dns/acme-dns/commit/63b9b648642f4f22978ae2a08548629fb5e086f2) ci: enable linter checks on all branches and disable recurring checks - [`b47f341`](https://github.com/acme-dns/acme-dns/commit/b47f3412382c69983b72132df6b972ad2eeda955) chore: update packages - [`7f625a7`](https://github.com/acme-dns/acme-dns/commit/7f625a7cf4f0c6d9606bbf3fc2e9e4be17ce38cb) Revert "chore: update packages" - [`dd73feb`](https://github.com/acme-dns/acme-dns/commit/dd73feba3b9c11bbb8b550a157d3fc701c91d63c) chore: manually upgrade some packages ### 📊 Changes **22 files changed** (+164 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/golangci-lint.yml` (+0 -8) ➕ `.golangci.yaml` (+15 -0) ➕ `.vscode/settings.json` (+5 -0) 📝 `go.mod` (+19 -20) 📝 `go.sum` (+77 -34) 📝 `main.go` (+2 -2) 📝 `pkg/acmedns/acmetxt.go` (+2 -1) 📝 `pkg/acmedns/interfaces.go` (+1 -0) 📝 `pkg/acmedns/util.go` (+2 -1) 📝 `pkg/acmedns/util_test.go` (+4 -3) 📝 `pkg/api/api_test.go` (+2 -2) 📝 `pkg/api/auth.go` (+2 -1) 📝 `pkg/api/challengeprovider.go` (+2 -1) 📝 `pkg/api/register.go` (+2 -1) 📝 `pkg/api/util.go` (+4 -2) 📝 `pkg/api/validation_test.go` (+2 -1) 📝 `pkg/database/db.go` (+4 -2) 📝 `pkg/database/db_test.go` (+4 -2) 📝 `pkg/nameserver/dns_test.go` (+6 -4) 📝 `pkg/nameserver/handler.go` (+2 -1) _...and 2 more files_ </details> ### 📄 Description I prefer to enable some more linters ;) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>