[PR #325] [MERGED] Refactoring #380

New issue

Closed

opened 2026-03-13 16:20:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:20:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/325
Author: @joohoi
Created: 12/25/2022
Status: ✅ Merged
Merged: 2/5/2026
Merged by: @joohoi

Base: master ← Head: refactoring

📝 Commits (10+)

1405e6a Refactor core
1572419 Re-added tests
f90ef44 Small fixes
3e0ee47 Add tests for acmetxt cidrslice and util funcs
1c4e1e5 Remove the last dangling reference to old logging package
34344b1 Refactoring (#327)
0450268 Updated dependencies, wrote changelog entry and fixed namespace for release
d20fae3 Merge remote-tracking branch 'origin/master' into refactoring
e0f9745 Refactoring - improving coverage (#371)
dc1a8f5 Merge remote-tracking branch 'origin/master' into refactoring

📊 Changes

57 files changed (+2761 additions, -1945 deletions)

View changed files

➕ .github/workflows/e2e.yml (+25 -0)
📝 .github/workflows/go_cov.yml (+22 -15)
📝 .github/workflows/golangci-lint.yml (+16 -16)
➕ .golangci.yaml (+30 -0)
➕ .vscode/settings.json (+5 -0)
📝 README.md (+5 -1)
➖ acmetxt.go (+0 -93)
➖ api.go (+0 -113)
➖ auth.go (+0 -93)
➖ auth_test.go (+0 -34)
📝 config.cfg (+10 -10)
➖ dns.go (+0 -245)
📝 go.mod (+42 -30)
📝 go.sum (+151 -491)
📝 main.go (+26 -181)
➖ main_test.go (+0 -111)
➕ pkg/acmedns/acmetxt.go (+47 -0)
➕ pkg/acmedns/acmetxt_test.go (+38 -0)
➕ pkg/acmedns/cidrslice.go (+35 -0)
➕ pkg/acmedns/cidrslice_test.go (+35 -0)

...and 37 more files

📄 Description

Huge refactoring PR to get acme-dns to a more maintainable state. Some new improvements done at the same time.

Changed logging to use zap.Logger
Logging to a file (finally) implemented on the application level
Fixed certmagic validation flow

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/325 **Author:** [@joohoi](https://github.com/joohoi) **Created:** 12/25/2022 **Status:** ✅ Merged **Merged:** 2/5/2026 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `refactoring` --- ### 📝 Commits (10+) - [`1405e6a`](https://github.com/acme-dns/acme-dns/commit/1405e6ab474ba2d356e6005c857a673afc736abe) Refactor core - [`1572419`](https://github.com/acme-dns/acme-dns/commit/157241994faf349a17f99fc66d8cc7d5c215ca24) Re-added tests - [`f90ef44`](https://github.com/acme-dns/acme-dns/commit/f90ef442a3466e6d3b23aa82a48d1065fd865c76) Small fixes - [`3e0ee47`](https://github.com/acme-dns/acme-dns/commit/3e0ee478b7017a682f93879ce931580420850b66) Add tests for acmetxt cidrslice and util funcs - [`1c4e1e5`](https://github.com/acme-dns/acme-dns/commit/1c4e1e55e43917e71dc512dcaa682aebc004fcad) Remove the last dangling reference to old logging package - [`34344b1`](https://github.com/acme-dns/acme-dns/commit/34344b1b35a46c2184e5f19aee9a65e524228d11) Refactoring (#327) - [`0450268`](https://github.com/acme-dns/acme-dns/commit/0450268becf611ceaa0ebb2620e2aac4bc895565) Updated dependencies, wrote changelog entry and fixed namespace for release - [`d20fae3`](https://github.com/acme-dns/acme-dns/commit/d20fae37c9b0536d4cfc72ccbb7773c8bbfb37ea) Merge remote-tracking branch 'origin/master' into refactoring - [`e0f9745`](https://github.com/acme-dns/acme-dns/commit/e0f9745182fd8927d41fc35c13c2b9c8250fed9b) Refactoring - improving coverage (#371) - [`dc1a8f5`](https://github.com/acme-dns/acme-dns/commit/dc1a8f54b1a1132572765c6ab91e5d78a5be5e7e) Merge remote-tracking branch 'origin/master' into refactoring ### 📊 Changes **57 files changed** (+2761 additions, -1945 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/e2e.yml` (+25 -0) 📝 `.github/workflows/go_cov.yml` (+22 -15) 📝 `.github/workflows/golangci-lint.yml` (+16 -16) ➕ `.golangci.yaml` (+30 -0) ➕ `.vscode/settings.json` (+5 -0) 📝 `README.md` (+5 -1) ➖ `acmetxt.go` (+0 -93) ➖ `api.go` (+0 -113) ➖ `auth.go` (+0 -93) ➖ `auth_test.go` (+0 -34) 📝 `config.cfg` (+10 -10) ➖ `dns.go` (+0 -245) 📝 `go.mod` (+42 -30) 📝 `go.sum` (+151 -491) 📝 `main.go` (+26 -181) ➖ `main_test.go` (+0 -111) ➕ `pkg/acmedns/acmetxt.go` (+47 -0) ➕ `pkg/acmedns/acmetxt_test.go` (+38 -0) ➕ `pkg/acmedns/cidrslice.go` (+35 -0) ➕ `pkg/acmedns/cidrslice_test.go` (+35 -0) _...and 37 more files_ </details> ### 📄 Description Huge refactoring PR to get acme-dns to a more maintainable state. Some new improvements done at the same time. - Changed logging to use zap.Logger - Logging to a file (finally) implemented on the application level - Fixed certmagic validation flow --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>