[PR #114] [MERGED] Enable fallback to unsynced lyrics when synced lyrics are unavailable #193

New issue

Closed

opened 2026-02-27 19:26:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/114
Author: @kerollosy
Created: 11/22/2024
Status: ✅ Merged
Merged: 11/28/2024
Merged by: @Lambada10

Base: master ← Head: musixmatch

📝 Commits (4)

81cc426 Rename syncedMusixmatch to unsyncedFallbackMusixmatch and update related methods and references
a522cea Update string resources to reflect unsynced lyrics fallback behavior
c9e2f5e Merge branch 'master' into musixmatch
47b831e Update strings.xml

📊 Changes

7 files changed (+17 additions, -16 deletions)

View changed files

📝 app/src/main/java/pl/lambada/songsync/data/UserSettingsController.kt (+5 -5)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/LyricsProviderService.kt (+3 -2)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/MusixmatchAPI.kt (+3 -3)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeViewModel.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchViewModel.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/settings/SettingsScreen.kt (+2 -2)
📝 app/src/main/res/values/strings.xml (+2 -2)

📄 Description

Previously, users could only toggle between synced and unsynced lyrics.
Now, if synced lyrics are unavailable, the app will automatically fall back to displaying unsynced lyrics.

Closes #112

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/114 **Author:** [@kerollosy](https://github.com/kerollosy) **Created:** 11/22/2024 **Status:** ✅ Merged **Merged:** 11/28/2024 **Merged by:** [@Lambada10](https://github.com/Lambada10) **Base:** `master` ← **Head:** `musixmatch` --- ### 📝 Commits (4) - [`81cc426`](https://github.com/Lambada10/SongSync/commit/81cc42669b08b0e6ee15aca9c3dd261577c81cc2) Rename syncedMusixmatch to unsyncedFallbackMusixmatch and update related methods and references - [`a522cea`](https://github.com/Lambada10/SongSync/commit/a522cea29360395a6e2397f807d60045ca359c16) Update string resources to reflect unsynced lyrics fallback behavior - [`c9e2f5e`](https://github.com/Lambada10/SongSync/commit/c9e2f5ea62549a715f466c5c2d36d32b9ceb9bed) Merge branch 'master' into musixmatch - [`47b831e`](https://github.com/Lambada10/SongSync/commit/47b831e33aab8edf83cacd6edcee0a42064c9447) Update strings.xml ### 📊 Changes **7 files changed** (+17 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/pl/lambada/songsync/data/UserSettingsController.kt` (+5 -5) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/LyricsProviderService.kt` (+3 -2) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/MusixmatchAPI.kt` (+3 -3) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeViewModel.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchViewModel.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/settings/SettingsScreen.kt` (+2 -2) 📝 `app/src/main/res/values/strings.xml` (+2 -2) </details> ### 📄 Description Previously, users could only toggle between synced and unsynced lyrics. Now, if synced lyrics are unavailable, the app will automatically fall back to displaying unsynced lyrics. Closes #112 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>