[PR #193] [CLOSED] Fix: skip Spotify provider during batch downloads when not selected (… #207

New issue

Closed

opened 2026-02-27 19:26:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/193
Author: @VipulNerd
Created: 10/2/2025
Status: ❌ Closed

Base: master ← Head: spotify-rate-limit-175

📝 Commits (3)

c810193 Fix: skip Spotify provider during batch downloads when not selected (fixes #175)
3932780 Fix: Pass selectedProvider correctly in HomeViewModel
01ca4a3 Guard BatchDownload debug log with AppConfig debug flag

📊 Changes

7 files changed (+30 additions, -12 deletions)

View changed files

➕ .idea/AndroidProjectSystem.xml (+6 -0)
📝 .idea/compiler.xml (+1 -1)
📝 .idea/gradle.xml (+1 -2)
📝 .idea/inspectionProfiles/Project_Default.xml (+3 -0)
📝 .idea/misc.xml (+0 -1)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeViewModel.kt (+6 -5)
📝 app/src/main/java/pl/lambada/songsync/util/LyricsUtils.kt (+13 -3)

📄 Description

…fixes #175)

bug: skip Spotify provider during batch downloads when not selected (#175)

Fixes #175

What:

Ensure batch downloads only call the user-selected provider.
Skip Spotify calls when Spotify is not the selected provider.

Why:

Prevents unnecessary Spotify API calls and rate limiting when users have not selected Spotify.

Testing:

Disable Spotify in Settings → run Batch Download → confirm no Spotify logs/calls.
Enable Spotify → run Batch Download → Spotify should be used.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/193 **Author:** [@VipulNerd](https://github.com/VipulNerd) **Created:** 10/2/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `spotify-rate-limit-175` --- ### 📝 Commits (3) - [`c810193`](https://github.com/Lambada10/SongSync/commit/c810193e05ddbba0bb4d11826c73ce6730b36759) Fix: skip Spotify provider during batch downloads when not selected (fixes #175) - [`3932780`](https://github.com/Lambada10/SongSync/commit/393278051c16bc2c11b460f23b1e6332ecaf843c) Fix: Pass selectedProvider correctly in HomeViewModel - [`01ca4a3`](https://github.com/Lambada10/SongSync/commit/01ca4a3c4e5c879ae2a6c8f020bfe7701310ed99) Guard BatchDownload debug log with AppConfig debug flag ### 📊 Changes **7 files changed** (+30 additions, -12 deletions) <details> <summary>View changed files</summary> ➕ `.idea/AndroidProjectSystem.xml` (+6 -0) 📝 `.idea/compiler.xml` (+1 -1) 📝 `.idea/gradle.xml` (+1 -2) 📝 `.idea/inspectionProfiles/Project_Default.xml` (+3 -0) 📝 `.idea/misc.xml` (+0 -1) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeViewModel.kt` (+6 -5) 📝 `app/src/main/java/pl/lambada/songsync/util/LyricsUtils.kt` (+13 -3) </details> ### 📄 Description …fixes #175) bug: skip Spotify provider during batch downloads when not selected (#175) Fixes #175 What: - Ensure batch downloads only call the user-selected provider. - Skip Spotify calls when Spotify is not the selected provider. Why: - Prevents unnecessary Spotify API calls and rate limiting when users have not selected Spotify. Testing: - Disable Spotify in Settings → run Batch Download → confirm no Spotify logs/calls. - Enable Spotify → run Batch Download → Spotify should be used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>