[PR #84] [MERGED] Show error message if there is an exception is starting server #91

New issue

Closed

opened 2026-03-04 23:24:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 23:24:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/84
Author: @raheelkhan
Created: 1/25/2019
Status: ✅ Merged
Merged: 1/30/2019
Merged by: @samuelwilliams

Base: master ← Head: show-permission-error

📝 Commits (4)

6e52955 throw exception if unable to start server
0e1a0b2 exit code should be 1 in case of exception
c50c55e create a separate subscriber to kill server if there is server exception
4009033 create new event called SERVER_START_FAIL specifically for the case where server cannot be started at all

📊 Changes

5 files changed (+43 additions, -3 deletions)

View changed files

📝 example/example.php (+2 -1)
📝 src/Event/Events.php (+7 -0)
📝 src/Event/Subscriber/EchoLogger.php (+2 -1)
➕ src/Event/Subscriber/ServerTerminator.php (+30 -0)
📝 src/Server.php (+2 -1)

📄 Description

Addressing the Issue #79

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/84 **Author:** [@raheelkhan](https://github.com/raheelkhan) **Created:** 1/25/2019 **Status:** ✅ Merged **Merged:** 1/30/2019 **Merged by:** [@samuelwilliams](https://github.com/samuelwilliams) **Base:** `master` ← **Head:** `show-permission-error` --- ### 📝 Commits (4) - [`6e52955`](https://github.com/yswery/PHP-DNS-SERVER/commit/6e52955b57e71f4a3e60eb3756002c9760065473) throw exception if unable to start server - [`0e1a0b2`](https://github.com/yswery/PHP-DNS-SERVER/commit/0e1a0b2a2cd2683e2721e33537dac22bdc15646c) exit code should be 1 in case of exception - [`c50c55e`](https://github.com/yswery/PHP-DNS-SERVER/commit/c50c55e3f99c08eed22d688d5e0b0f8c81c881cd) create a separate subscriber to kill server if there is server exception - [`4009033`](https://github.com/yswery/PHP-DNS-SERVER/commit/40090333b8350856b8487ad3a746fc7f3e4a9329) create new event called SERVER_START_FAIL specifically for the case where server cannot be started at all ### 📊 Changes **5 files changed** (+43 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `example/example.php` (+2 -1) 📝 `src/Event/Events.php` (+7 -0) 📝 `src/Event/Subscriber/EchoLogger.php` (+2 -1) ➕ `src/Event/Subscriber/ServerTerminator.php` (+30 -0) 📝 `src/Server.php` (+2 -1) </details> ### 📄 Description Addressing the Issue #79 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>