[PR #91] [MERGED] Send an optional `client` parameter to resolvers #95

New issue

Closed

opened 2026-03-04 23:24:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 23:24:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/91
Author: @n1c
Created: 9/26/2019
Status: ✅ Merged
Merged: 10/19/2019
Merged by: @samuelwilliams

Base: master ← Head: master

📝 Commits (1)

1cc244c Sent an optional client parameter to resolvers

📊 Changes

6 files changed (+8 additions, -8 deletions)

View changed files

📝 src/Resolver/AbstractResolver.php (+1 -1)
📝 src/Resolver/ResolverInterface.php (+1 -1)
📝 src/Resolver/StackableResolver.php (+1 -1)
📝 src/Resolver/SystemResolver.php (+1 -1)
📝 src/Server.php (+3 -3)
📝 tests/DummyResolver.php (+1 -1)

📄 Description

For discussion - can we send the client (address making the request) down to the resolver?

This would allow for complex resolvers to be created that have different rules per-client.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/91 **Author:** [@n1c](https://github.com/n1c) **Created:** 9/26/2019 **Status:** ✅ Merged **Merged:** 10/19/2019 **Merged by:** [@samuelwilliams](https://github.com/samuelwilliams) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`1cc244c`](https://github.com/yswery/PHP-DNS-SERVER/commit/1cc244c2eb31a257061c1f9faebf64a66fa46fce) Sent an optional `client` parameter to resolvers ### 📊 Changes **6 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/Resolver/AbstractResolver.php` (+1 -1) 📝 `src/Resolver/ResolverInterface.php` (+1 -1) 📝 `src/Resolver/StackableResolver.php` (+1 -1) 📝 `src/Resolver/SystemResolver.php` (+1 -1) 📝 `src/Server.php` (+3 -3) 📝 `tests/DummyResolver.php` (+1 -1) </details> ### 📄 Description For discussion - can we send the client (address making the request) down to the resolver? This would allow for complex resolvers to be created that have different rules per-client. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>