mirror of
https://github.com/yswery/PHP-DNS-SERVER.git
synced 2026-04-25 17:25:53 +03:00
[PR #64] [MERGED] Event subscriber #79
Labels
No labels
bug
enhancement
enhancement
hacktoberfest
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PHP-DNS-SERVER#79
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/64
Author: @ivanstan
Created: 9/14/2018
Status: ✅ Merged
Merged: 9/15/2018
Merged by: @samuelwilliams
Base:
version-1← Head:feature/event-subscriber📝 Commits (3)
0273130Event subscribersd57ee46Event subscribers - adds exception event09e02e7EchoLogger rewritten to extend EventSubscriberInterface📊 Changes
14 files changed (+378 additions, -29 deletions)
View changed files
➕
docs/events.md(+43 -0)📝
example/example.php(+1 -1)📝
src/EchoLogger.php(+43 -2)➕
src/Event/Event.php(+12 -0)➕
src/Event/EventSubscriberInterface.php(+8 -0)➕
src/Event/EventSubscriberTrait.php(+47 -0)➕
src/Event/ExceptionEvent.php(+18 -0)➕
src/Event/MessageEvent.php(+29 -0)➕
src/Event/QueryReceiveEvent.php(+20 -0)➕
src/Event/QueryResponseEvent.php(+8 -0)➕
src/Event/ServerStartEvent.php(+20 -0)📝
src/Server.php(+22 -26)➕
src/Tests/EventSubscriberTest.php(+62 -0)➕
src/Tests/ExampleEventSubscriber.php(+45 -0)📄 Description
Possibility to decouple additional logic for (caching, logging, etc) from server class using event subscribers.
Merge request defines event classes, implements throwing events in server class, adds tests and documentation for developers explaining feature usage.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.