[PR #736] [MERGED] Fix key bindings #873

Closed
opened 2026-03-03 00:23:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/736
Author: @Rokt33r
Created: 12/23/2020
Status: Merged
Merged: 12/23/2020
Merged by: @Rokt33r

Base: masterHead: fix-key-bindings


📝 Commits (10+)

  • 9d39341 Refactor noteDetailFocusTitleInputEventEmitter
  • 8b9e511 Rename parseNumberStringOrReturnZero
  • 2ccf175 Refactor boostHubLoginRequestEventEmitter
  • c1ddef2 Refactor boostHubLoginEventEmitter
  • 0f1bc94 Refactor boostHubNavigateRequestEventEmitter
  • 1f69f8b Refactor boostHubTeamCreateEventEmitter
  • bc6ee92 Move isChildNode to lib/dom
  • 1a63fc5 Refactor boostHubTeamUpdateEventEmitter
  • 5a4c3a1 Refactor boostHubTeamDeleteEventEmitter
  • 1f386ad Refactor boostHubAccountDeleteEventEmitter

📊 Changes

29 files changed (+642 additions, -382 deletions)

View changed files

📝 package-lock.json (+9 -3)
📝 package.json (+1 -0)
📝 src/components/App.tsx (+18 -20)
📝 src/components/PreferencesModal/PreferencesModal.tsx (+6 -5)
📝 src/components/Router.tsx (+5 -4)
📝 src/components/atoms/BoostHubWebview.tsx (+10 -10)
📝 src/components/molecules/NotePageToolbarNoteHeader.tsx (+16 -7)
📝 src/components/molecules/SearchModalNoteResultItem.tsx (+41 -1)
📝 src/components/molecules/StorageNavigatorFragment.tsx (+26 -4)
📝 src/components/organisms/BoostHubIntroModal.tsx (+2 -2)
📝 src/components/organisms/BoostHubSignInForm.tsx (+6 -8)
📝 src/components/organisms/NoteDetail.tsx (+13 -0)
📝 src/components/organisms/NotePageToolbar.tsx (+194 -38)
📝 src/components/organisms/NoteStorageNavigator.tsx (+2 -12)
📝 src/components/pages/BoostHubTeamsShowPage.tsx (+3 -6)
📝 src/components/pages/NotePage.tsx (+8 -47)
📝 src/components/pages/WikiNotePage.tsx (+4 -4)
src/electron/ipc.ts (+13 -0)
📝 src/electron/menu.ts (+85 -31)
📝 src/lib/dom.ts (+17 -0)

...and 9 more files

📄 Description

Partially fixing #700


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/736 **Author:** [@Rokt33r](https://github.com/Rokt33r) **Created:** 12/23/2020 **Status:** ✅ Merged **Merged:** 12/23/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `fix-key-bindings` --- ### 📝 Commits (10+) - [`9d39341`](https://github.com/BoostIO/BoostNote-App/commit/9d39341950b4b65e18ea8c3cd1678de1aa861088) Refactor noteDetailFocusTitleInputEventEmitter - [`8b9e511`](https://github.com/BoostIO/BoostNote-App/commit/8b9e511d1a59ad10b2ddff11edfd7fbe0395ed7f) Rename parseNumberStringOrReturnZero - [`2ccf175`](https://github.com/BoostIO/BoostNote-App/commit/2ccf17585e77a70d7bdea9fcb315331fbb344338) Refactor boostHubLoginRequestEventEmitter - [`c1ddef2`](https://github.com/BoostIO/BoostNote-App/commit/c1ddef2f42b2489f0e159ea998f9045c569a41db) Refactor boostHubLoginEventEmitter - [`0f1bc94`](https://github.com/BoostIO/BoostNote-App/commit/0f1bc94ad74dc37d549fe606adfc317e78b28488) Refactor boostHubNavigateRequestEventEmitter - [`1f69f8b`](https://github.com/BoostIO/BoostNote-App/commit/1f69f8b1151bb6b637693d1df3521eefd4869107) Refactor boostHubTeamCreateEventEmitter - [`bc6ee92`](https://github.com/BoostIO/BoostNote-App/commit/bc6ee92f5690f5c5392f133691276413532235ae) Move isChildNode to lib/dom - [`1a63fc5`](https://github.com/BoostIO/BoostNote-App/commit/1a63fc51a7054128cd03385215e204c40cfe8522) Refactor boostHubTeamUpdateEventEmitter - [`5a4c3a1`](https://github.com/BoostIO/BoostNote-App/commit/5a4c3a1ce087a4e551d57424ebd46b74d5e1ea55) Refactor boostHubTeamDeleteEventEmitter - [`1f386ad`](https://github.com/BoostIO/BoostNote-App/commit/1f386ad4160583c6fbe0e6401462e5aa0559dd1d) Refactor boostHubAccountDeleteEventEmitter ### 📊 Changes **29 files changed** (+642 additions, -382 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+9 -3) 📝 `package.json` (+1 -0) 📝 `src/components/App.tsx` (+18 -20) 📝 `src/components/PreferencesModal/PreferencesModal.tsx` (+6 -5) 📝 `src/components/Router.tsx` (+5 -4) 📝 `src/components/atoms/BoostHubWebview.tsx` (+10 -10) 📝 `src/components/molecules/NotePageToolbarNoteHeader.tsx` (+16 -7) 📝 `src/components/molecules/SearchModalNoteResultItem.tsx` (+41 -1) 📝 `src/components/molecules/StorageNavigatorFragment.tsx` (+26 -4) 📝 `src/components/organisms/BoostHubIntroModal.tsx` (+2 -2) 📝 `src/components/organisms/BoostHubSignInForm.tsx` (+6 -8) 📝 `src/components/organisms/NoteDetail.tsx` (+13 -0) 📝 `src/components/organisms/NotePageToolbar.tsx` (+194 -38) 📝 `src/components/organisms/NoteStorageNavigator.tsx` (+2 -12) 📝 `src/components/pages/BoostHubTeamsShowPage.tsx` (+3 -6) 📝 `src/components/pages/NotePage.tsx` (+8 -47) 📝 `src/components/pages/WikiNotePage.tsx` (+4 -4) ➕ `src/electron/ipc.ts` (+13 -0) 📝 `src/electron/menu.ts` (+85 -31) 📝 `src/lib/dom.ts` (+17 -0) _...and 9 more files_ </details> ### 📄 Description Partially fixing #700 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:23:35 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#873
No description provided.