[PR #873] [MERGED] Bug/zombie realtime connection #964

Closed
opened 2026-03-03 00:23:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/873
Author: @ButteryCrumpet
Created: 3/17/2021
Status: Merged
Merged: 3/17/2021
Merged by: @Davy-c

Base: masterHead: bug/zombie-realtime-connection


📝 Commits (4)

  • dc733db stop calling open event on VirtualConnections not in CONNECTING state
  • aa1a832 move repeated logic to method
  • 032ccda remove unecessary hook dep
  • 49bd66d revert added brackets

📊 Changes

3 files changed (+23 additions, -16 deletions)

View changed files

📝 src/cloud/lib/editor/hooks/useRealtime.ts (+8 -3)
📝 src/cloud/lib/realtime/client/VirtualConnection.ts (+9 -0)
📝 src/cloud/lib/realtime/client/multiplexConnection.ts (+6 -13)

📄 Description

Fix bug causing real-time to think it is connected after a timeout


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/873 **Author:** [@ButteryCrumpet](https://github.com/ButteryCrumpet) **Created:** 3/17/2021 **Status:** ✅ Merged **Merged:** 3/17/2021 **Merged by:** [@Davy-c](https://github.com/Davy-c) **Base:** `master` ← **Head:** `bug/zombie-realtime-connection` --- ### 📝 Commits (4) - [`dc733db`](https://github.com/BoostIO/BoostNote-App/commit/dc733db7c023bec9418cc3de49425b638077fbb8) stop calling open event on VirtualConnections not in CONNECTING state - [`aa1a832`](https://github.com/BoostIO/BoostNote-App/commit/aa1a83276e0161c2aa8838cee570085809057f71) move repeated logic to method - [`032ccda`](https://github.com/BoostIO/BoostNote-App/commit/032ccda0b751a85f8a365f581b05c477f982a666) remove unecessary hook dep - [`49bd66d`](https://github.com/BoostIO/BoostNote-App/commit/49bd66d0e7203faba8fa041ed360fb9795347c3a) revert added brackets ### 📊 Changes **3 files changed** (+23 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/cloud/lib/editor/hooks/useRealtime.ts` (+8 -3) 📝 `src/cloud/lib/realtime/client/VirtualConnection.ts` (+9 -0) 📝 `src/cloud/lib/realtime/client/multiplexConnection.ts` (+6 -13) </details> ### 📄 Description Fix bug causing real-time to think it is connected after a timeout --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:23:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#964
No description provided.