[PR #364] [MERGED] French #736

New issue

Closed

opened 2026-03-03 00:22:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:22:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/364
Author: @Hadrien-lcrx
Created: 2/25/2020
Status: ✅ Merged
Merged: 3/3/2020
Merged by: @Rokt33r

Base: master ← Head: french

📝 Commits (4)

46c06fd Add French, correct Spanish
e70918d "Missed in previous commit"
c636399 Typos and formulations
c7dc322 Remove git files

📊 Changes

5 files changed (+171 additions, -6 deletions)

View changed files

📝 src/components/PreferencesModal/GeneralTab.tsx (+1 -0)
📝 src/lib/i18n.ts (+3 -1)
📝 src/lib/preferences.ts (+1 -0)
📝 src/locales/esEs.ts (+5 -5)
➕ src/locales/frFR.ts (+161 -0)

📄 Description

Added French translation
Minor corrections to Spanish translation
Renaming esEs.ts in src/locales to esES.ts for consistency. Modified corresponding import statements in src/lib/i18n.ts
Note: In src/locales, on line 60 of any .ts files, you have a 'note.date'key. It's "ago" in English, which would render as "20 days ago". In French, it's "il y a", which would render as "Il y a 20 jours". So the locale ends up in front of the value instead of after. Same thing in Spanish: "Hace 20 días". I would verify how this specific locale renders in these languages, to make sure language specific grammar is respected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/364 **Author:** [@Hadrien-lcrx](https://github.com/Hadrien-lcrx) **Created:** 2/25/2020 **Status:** ✅ Merged **Merged:** 3/3/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `french` --- ### 📝 Commits (4) - [`46c06fd`](https://github.com/BoostIO/BoostNote-App/commit/46c06fd6b0ed206f69515b06fdf721534b2c23bc) Add French, correct Spanish - [`e70918d`](https://github.com/BoostIO/BoostNote-App/commit/e70918dfb740836c9f6c54f3bdbabbd6bc93f929) "Missed in previous commit" - [`c636399`](https://github.com/BoostIO/BoostNote-App/commit/c636399db8785489063466840150664654737410) Typos and formulations - [`c7dc322`](https://github.com/BoostIO/BoostNote-App/commit/c7dc322ad061a1ecf864a344072db2313227d055) Remove git files ### 📊 Changes **5 files changed** (+171 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/components/PreferencesModal/GeneralTab.tsx` (+1 -0) 📝 `src/lib/i18n.ts` (+3 -1) 📝 `src/lib/preferences.ts` (+1 -0) 📝 `src/locales/esEs.ts` (+5 -5) ➕ `src/locales/frFR.ts` (+161 -0) </details> ### 📄 Description - Added French translation - Minor corrections to Spanish translation - Renaming `esEs.ts` in `src/locales` to `esES.ts` for consistency. Modified corresponding import statements in `src/lib/i18n.ts` - **Note**: In `src/locales`, on line 60 of any `.ts` files, you have a `'note.date'`key. It's "ago" in English, which would render as "20 days **ago**". In French, it's "il y a", which would render as "**Il y a** 20 jours". So the locale ends up in front of the value instead of after. Same thing in Spanish: "**Hace** 20 días". I would verify how this specific locale renders in these languages, to make sure language specific grammar is respected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:22:58 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-03 00:23:35 +03:00

[PR #736] [MERGED] Fix key bindings #873

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#736

No description provided.

Rows
Columns