[PR #445] [MERGED] RPM build target | #441 #755

Closed
opened 2026-03-03 00:23:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/445
Author: @jhdcruz
Created: 4/27/2020
Status: Merged
Merged: 5/1/2020
Merged by: @Rokt33r

Base: masterHead: rpm-build


📝 Commits (1)

  • f909733 added rpm build target for electron-builder

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 package.json (+1 -0)

📄 Description

Requires rpm build essentials

  • Addresses Issue #441

The project's electron-builder build script are based on the current architecture/OS of the user, so it probably needs redhat-based machines (ex. Fedora, CentOS, etc.) to achieve .rpm builds.


I also suggest seperating electron-builder configurations to its own dedicated file: electron-builder.yml to avoid the cluttering of package.json.

json, json5, toml or js (exported configuration or function that produces configuration) formats also supported.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/445 **Author:** [@jhdcruz](https://github.com/jhdcruz) **Created:** 4/27/2020 **Status:** ✅ Merged **Merged:** 5/1/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `rpm-build` --- ### 📝 Commits (1) - [`f909733`](https://github.com/BoostIO/BoostNote-App/commit/f909733656e5ad2580c4dc8a225ac677b7fbe941) added rpm build target for electron-builder ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+1 -0) </details> ### 📄 Description **Requires rpm build essentials** - Addresses Issue #441 The project's `electron-builder` build script are based on the current architecture/OS of the user, so it probably needs redhat-based machines (ex. Fedora, CentOS, etc.) to achieve `.rpm` builds. ----- I also **suggest** seperating `electron-builder` configurations to its own dedicated file: `electron-builder.yml` to avoid the cluttering of `package.json`. > `json`, `json5`, `toml` or `js` (exported configuration or function that produces configuration) formats also supported. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:23:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#755
No description provided.