mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-26 21:05:55 +03:00
[PR #982] [MERGED] Update cursor and focus handling for NoteDetail #1059
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#1059
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BoostIO/BoostNote-App/pull/982
Author: @Komediruzecki
Created: 6/3/2021
Status: ✅ Merged
Merged: 6/4/2021
Merged by: @Rokt33r
Base:
master← Head:feature/improve-note-detail-cursor-behaviour📝 Commits (1)
4c50ce2Update cursor and focus handling for NoteDetail📊 Changes
4 files changed (+70 additions, -36 deletions)
View changed files
📝
src/components/organisms/NoteDetail.tsx(+38 -14)📝
src/components/organisms/SearchModal.tsx(+7 -2)📝
src/components/pages/WikiNotePage.tsx(+23 -20)📝
src/lib/generalStatus.ts(+2 -0)📄 Description
Update cursor and focus handling for NoteDetail
Fix cursor position handling (remember across view modes)
Fix cursor update from global search (use generalStatus)
Fix changing view mode does not copy markers from serach dialog
This should resolve #755 and additionaly local search not marking found items after view mode change.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.