[PR #349] [MERGED] Ui enhancements for snapshot addition #1117

New issue

Closed

opened 2026-03-01 14:48:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:48:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/349
Author: @cdvv7788
Created: 7/1/2020
Status: ✅ Merged
Merged: 7/2/2020
Merged by: @pirate

Base: django ← Head: ui-enhancements

📝 Commits (2)

c971e00 feat: Add stdout from process to the template
364c575 feat: Handle empty URL case

📊 Changes

4 files changed (+59 additions, -8 deletions)

View changed files

📝 archivebox/config/__init__.py (+10 -0)
📝 archivebox/core/views.py (+22 -8)
📝 archivebox/themes/default/add_links.html (+3 -0)
📝 archivebox/util.py (+24 -0)

📄 Description

Summary

Adds stdout to the template, resembling what the console sees
Changes the flow a little. Instead of redirecting, the user is kept in the add page. A new link to go back is added.
Handles the case where the box is empty. Before it was returning an error, now it returns a message.

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Archived data layout on disk

Notes:

This includes the use of the safe filter in the template. I think that no user authored content is actually displayed, so there should be no issue with it.
The ansi_to_html conversion could be performed in a template filter. I can move it there if necessary.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/349 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 7/1/2020 **Status:** ✅ Merged **Merged:** 7/2/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `django` ← **Head:** `ui-enhancements` --- ### 📝 Commits (2) - [`c971e00`](https://github.com/ArchiveBox/ArchiveBox/commit/c971e00c9cd746085a5a9f8605a45f231e6558f0) feat: Add stdout from process to the template - [`364c575`](https://github.com/ArchiveBox/ArchiveBox/commit/364c5752d827c87a927bed00e89e4e3d7c5b6e4a) feat: Handle empty URL case ### 📊 Changes **4 files changed** (+59 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/config/__init__.py` (+10 -0) 📝 `archivebox/core/views.py` (+22 -8) 📝 `archivebox/themes/default/add_links.html` (+3 -0) 📝 `archivebox/util.py` (+24 -0) </details> ### 📄 Description # Summary - Adds stdout to the template, resembling what the console sees - Changes the flow a little. Instead of redirecting, the user is kept in the `add` page. A new link to go back is added. - Handles the case where the box is empty. Before it was returning an error, now it returns a message. # Changes these areas - [ ] Bugfixes - [x] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Archived data layout on disk # Notes: - This includes the use of the `safe` filter in the template. I think that no user authored content is actually displayed, so there should be no issue with it. - The `ansi_to_html` conversion could be performed in a template filter. I can move it there if necessary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>