mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1117] Feature request: Add ability to point ArchiveBox to a custom favicon service instead of Google #3721
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#3721
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pirate on GitHub (Mar 9, 2023).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1117
Just found out that https://github.com/mat/besticon exists. This would allow us to point ArchiveBox at a self-hosted replacement for the Google favicon service we currently use.
The current solution has always mildly irked me as a suboptimal way we leak archived domains to a 3rd party, which is why I document how to disable it here: https://docs.archivebox.io/en/latest/Security-Overview.html#stealth-mode, but it would be nice to provide an alternative other than disabling it entirely.
I'm imagining something like:
archivebox config --set FAVICON_PROVIDER='https://www.google.com/s2/favicons?domain={}'(the default)that can be set to anything, e.g.:
archivebox config --set FAVICON_PROVIDER='https://someselfhostedservice.example.com/?q={}&format=png&size=64x64'@pirate commented on GitHub (Jun 13, 2023):
closing because PR was merged, thanks!