[PR #1146] [MERGED] Add FAVICON_PROVIDER option for custom favicon service #4342

New issue

Closed

opened 2026-03-15 01:39:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:39:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1146
Author: @mrled
Created: 5/6/2023
Status: ✅ Merged
Merged: 5/6/2023
Merged by: @pirate

Base: dev ← Head: add-favicon-provider

📝 Commits (1)

1e50ca2 Add FAVICON_PROVIDER option for custom favicon service

📊 Changes

3 files changed (+6 additions, -4 deletions)

View changed files

📝 archivebox/config.py (+2 -1)
📝 archivebox/extractors/favicon.py (+2 -1)
📝 archivebox/index/schema.py (+2 -2)

📄 Description

Summary

Add FAVICON_PROVIDER option to allow configuring any favicon service.

Tested with The Favicon Finder (a demo deployment of mat/besticon mentioned in the related issue), and also with Favicon Kit.

e.g.

archivebox config --set FAVICON_PROVIDER='https://besticon-demo.herokuapp.com/icon?url={}&size=32..64..64'

Questions

I noticed that the Google URL was hard-coded in two places: archivebox/extractors/favicon.py and archivebox/index/schema.py. I made changes in both, but I'm not sure if I should have done the latter -- the top of that file says not to add any more features to the file. Is it better to leave it as is, with the old hard-coded Google URL, or change it?

#1117

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1146 **Author:** [@mrled](https://github.com/mrled) **Created:** 5/6/2023 **Status:** ✅ Merged **Merged:** 5/6/2023 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `add-favicon-provider` --- ### 📝 Commits (1) - [`1e50ca2`](https://github.com/ArchiveBox/ArchiveBox/commit/1e50ca243e4a57b12b9c253bcf908cfb3be02b13) Add FAVICON_PROVIDER option for custom favicon service ### 📊 Changes **3 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/config.py` (+2 -1) 📝 `archivebox/extractors/favicon.py` (+2 -1) 📝 `archivebox/index/schema.py` (+2 -2) </details> ### 📄 Description # Summary Add `FAVICON_PROVIDER` option to allow configuring any favicon service. Tested with [The Favicon Finder](https://besticon-demo.herokuapp.com/) (a demo deployment of [mat/besticon](https://github.com/mat/besticon) mentioned in the related issue), and also with [Favicon Kit](faviconkit.com). e.g. ```sh archivebox config --set FAVICON_PROVIDER='https://besticon-demo.herokuapp.com/icon?url={}&size=32..64..64' ``` # Questions I noticed that the Google URL was hard-coded in two places: `archivebox/extractors/favicon.py` and `archivebox/index/schema.py`. I made changes in both, but I'm not sure if I should have done the latter -- the top of that file says not to add any more features to the file. Is it better to leave it as is, with the old hard-coded Google URL, or change it? # Related issues #1117 # Changes these areas - [ ] Bugfixes - [x] Feature behavior - [ ] Command line interface - [x] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:39:19 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4342

No description provided.

Rows
Columns