[PR #778] [MERGED] Add web review submissions, threads, and attachments workflows #779

New issue

Closed

opened 2026-02-26 22:32:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/778
Author: @rudrankriyam
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/web-review-resolution

📝 Commits (10+)

d06d89d add web review data client for unresolved flows
46c3083 add web commands for submissions threads and attachments
eec4a5a harden web iris guardrails for user safety
3cc9539 Sanitize review attachment download filenames
cbfa67e refactor web review into app-centric list/show flow
4f9801a Merge pull request #779 from rudrankriyam/cursor/attachment-filename-path-traversal-7b2b
130d52e fix web auth login reliability for interactive 2FA and macOS TLS fallback
bc97fc3 render web review list in structured table and markdown formats
4f4f488 render web review show in table output and strip message HTML markup
ac2fb83 simplify web review show table rows for human readability

📊 Changes

14 files changed (+3195 additions, -25 deletions)

View changed files

📝 README.md (+12 -7)
➕ internal/cli/cmdtest/web_review_commands_test.go (+153 -0)
📝 internal/cli/docs/templates/ASC.md (+1 -1)
📝 internal/cli/web/web.go (+5 -3)
📝 internal/cli/web/web_apps.go (+2 -2)
📝 internal/cli/web/web_auth.go (+67 -10)
➕ internal/cli/web/web_auth_test.go (+165 -0)
➕ internal/cli/web/web_review.go (+886 -0)
➕ internal/cli/web/web_review_test.go (+232 -0)
➕ internal/cli/web/web_session_flags.go (+53 -0)
📝 internal/web/auth.go (+145 -2)
📝 internal/web/auth_test.go (+148 -0)
➕ internal/web/review.go (+896 -0)
➕ internal/web/review_workflows_test.go (+430 -0)

📄 Description

Summary

Add an internal web/iris review client for review submissions, resolution-center traversal, rejection parsing, and signed attachment downloads.
Add new detached CLI groups for unofficial web review operations: asc web submissions (list/show/items) and asc web review (threads/messages/rejections/draft/attachments list/download).
Add RED->GREEN coverage for parsing behavior and command contracts, including required-flag validation and unsupported state checks.

Linked issues

Closes #775
Closes #776

Test plan

go test ./internal/web ./internal/cli/web ./internal/cli/cmdtest -run 'Web|Review'
make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/778 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/web-review-resolution` --- ### 📝 Commits (10+) - [`d06d89d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d06d89d0b12823e51d807bc3aab3307cee5e9a85) add web review data client for unresolved flows - [`46c3083`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/46c3083e20091a0df7716859c51daf4c3a500f90) add web commands for submissions threads and attachments - [`eec4a5a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/eec4a5a2bf4a331b57523a6a7acd761672659fa7) harden web iris guardrails for user safety - [`3cc9539`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3cc95391eb4ee19eae5eaf59cef4c8919f85aabf) Sanitize review attachment download filenames - [`cbfa67e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cbfa67e1778394f72bff3b04448debe166d97d46) refactor web review into app-centric list/show flow - [`4f9801a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4f9801a9017f6ffece58116e7a51273e70b3fa57) Merge pull request #779 from rudrankriyam/cursor/attachment-filename-path-traversal-7b2b - [`130d52e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/130d52eedcded354af7b9e7792b01c94256fd840) fix web auth login reliability for interactive 2FA and macOS TLS fallback - [`bc97fc3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/bc97fc30304ead695f4d2eef5159eef326871edf) render web review list in structured table and markdown formats - [`4f4f488`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4f4f488208036e3e64b639c05b440fb69ad85cd0) render web review show in table output and strip message HTML markup - [`ac2fb83`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ac2fb831b8257c9ff1e82f399a1bc9feb1dd98bc) simplify web review show table rows for human readability ### 📊 Changes **14 files changed** (+3195 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+12 -7) ➕ `internal/cli/cmdtest/web_review_commands_test.go` (+153 -0) 📝 `internal/cli/docs/templates/ASC.md` (+1 -1) 📝 `internal/cli/web/web.go` (+5 -3) 📝 `internal/cli/web/web_apps.go` (+2 -2) 📝 `internal/cli/web/web_auth.go` (+67 -10) ➕ `internal/cli/web/web_auth_test.go` (+165 -0) ➕ `internal/cli/web/web_review.go` (+886 -0) ➕ `internal/cli/web/web_review_test.go` (+232 -0) ➕ `internal/cli/web/web_session_flags.go` (+53 -0) 📝 `internal/web/auth.go` (+145 -2) 📝 `internal/web/auth_test.go` (+148 -0) ➕ `internal/web/review.go` (+896 -0) ➕ `internal/web/review_workflows_test.go` (+430 -0) </details> ### 📄 Description ## Summary - Add an internal web/iris review client for review submissions, resolution-center traversal, rejection parsing, and signed attachment downloads. - Add new detached CLI groups for unofficial web review operations: `asc web submissions` (list/show/items) and `asc web review` (threads/messages/rejections/draft/attachments list/download). - Add RED->GREEN coverage for parsing behavior and command contracts, including required-flag validation and unsupported state checks. ## Linked issues - Closes #775 - Closes #776 ## Test plan - [x] `go test ./internal/web ./internal/cli/web ./internal/cli/cmdtest -run 'Web|Review'` - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>