[PR #772] [MERGED] fix: increase upload timeout default and improve timeout hints #775

New issue

Closed

opened 2026-02-26 22:32:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/772
Author: @rudrankriyam
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/app-store-experiment-treatment-localizations-9894

📝 Commits (4)

cafcbea test: add red coverage for upload timeout hints
18ed8ab fix: increase upload timeout and improve timeout hint
51af4fe fix: raise upload timeout hint above new default
45a05a6 Merge pull request #773 from rudrankriyam/cursor/upload-timeout-hint-value-aefa

📊 Changes

4 files changed (+64 additions, -4 deletions)

View changed files

📝 internal/asc/client_core.go (+1 -1)
➕ internal/asc/client_core_timeout_test.go (+24 -0)
📝 internal/cli/shared/errfmt/errfmt.go (+18 -1)
📝 internal/cli/shared/errfmt/errfmt_test.go (+21 -2)

📄 Description

Linked Issue

Fixes #771

Summary

Increase the default upload timeout from 60s to 300s so larger IPA uploads have sufficient headroom.
Improve timeout classification for context deadline exceeded:
- Upload-specific timeouts now suggest ASC_UPLOAD_TIMEOUT (for example, ASC_UPLOAD_TIMEOUT=600s).
- Non-upload request timeouts continue to suggest ASC_TIMEOUT.
Add tests covering upload-timeout defaults/env override and the upload-vs-request timeout hint behavior.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/772 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/app-store-experiment-treatment-localizations-9894` --- ### 📝 Commits (4) - [`cafcbea`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cafcbea76ce1296aee334560a03a2cb5b485e5c0) test: add red coverage for upload timeout hints - [`18ed8ab`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/18ed8abfe1e2c98b0bae8ea0cec7d60b33da9260) fix: increase upload timeout and improve timeout hint - [`51af4fe`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/51af4fe542c714d9ef0a59b4ded6b9d4db2e5bc6) fix: raise upload timeout hint above new default - [`45a05a6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/45a05a62926b36706c6f3319cc3ebaaa04142be7) Merge pull request #773 from rudrankriyam/cursor/upload-timeout-hint-value-aefa ### 📊 Changes **4 files changed** (+64 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_core.go` (+1 -1) ➕ `internal/asc/client_core_timeout_test.go` (+24 -0) 📝 `internal/cli/shared/errfmt/errfmt.go` (+18 -1) 📝 `internal/cli/shared/errfmt/errfmt_test.go` (+21 -2) </details> ### 📄 Description ## Linked Issue Fixes #771 ## Summary - Increase the default upload timeout from 60s to 300s so larger IPA uploads have sufficient headroom. - Improve timeout classification for `context deadline exceeded`: - Upload-specific timeouts now suggest `ASC_UPLOAD_TIMEOUT` (for example, `ASC_UPLOAD_TIMEOUT=600s`). - Non-upload request timeouts continue to suggest `ASC_TIMEOUT`. - Add tests covering upload-timeout defaults/env override and the upload-vs-request timeout hint behavior. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>