[PR #723] [MERGED] Benchstat output regex #739

New issue

Closed

opened 2026-02-26 22:32:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/723
Author: @cursor[bot]
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/22/2026
Merged by: @rudrankriyam

Base: perf/hot-path-optimizations-and-bench-suite ← Head: cursor/benchstat-output-regex-7293

📝 Commits (1)

4a75ca3 Fix benchstat parser for modern p-value output

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 scripts/bench-comment.js (+1 -1)

📄 Description

Summary

The benchstat regex in scripts/bench-comment.js was updated to correctly parse modern benchstat output, which includes sample counts (e.g., n=3+3). This ensures benchmark results are properly formatted in PR comments instead of falling back to raw output.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/723 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/22/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `perf/hot-path-optimizations-and-bench-suite` ← **Head:** `cursor/benchstat-output-regex-7293` --- ### 📝 Commits (1) - [`4a75ca3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4a75ca3cc7a12e4be3e5b864c4b89377ed12ac18) Fix benchstat parser for modern p-value output ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `scripts/bench-comment.js` (+1 -1) </details> ### 📄 Description ## Summary The `benchstat` regex in `scripts/bench-comment.js` was updated to correctly parse modern `benchstat` output, which includes sample counts (e.g., `n=3+3`). This ensures benchmark results are properly formatted in PR comments instead of falling back to raw output. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>