[PR #739] [MERGED] Add hint for app privacy/data usage API errors #750

New issue

Closed

opened 2026-02-26 22:32:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/739
Author: @omar16100
Created: 2/23/2026
Status: ✅ Merged
Merged: 2/23/2026
Merged by: @rudrankriyam

Base: main ← Head: feedback/privacy-error-hint

📝 Commits (2)

cf61269 feat(errfmt): add hint for app privacy/data usage errors
0d84f46 test(errfmt): prioritize privacy hint and tighten assertions

📊 Changes

2 files changed (+79 additions, -0 deletions)

View changed files

📝 internal/cli/shared/errfmt/errfmt.go (+15 -0)
📝 internal/cli/shared/errfmt/errfmt_test.go (+64 -0)

📄 Description

Summary

Adds detection of appDataUsages / appDataUsagesPublications in API error messages within errfmt.Classify()
Surfaces actionable hint directing users to configure privacy declarations in App Store Connect web UI — the API does not expose these endpoints (confirmed against docs/openapi/paths.txt)
~55 lines across errfmt.go + errfmt_test.go

Motivation

When asc submit create fails due to incomplete privacy declarations, the error references /v1/appDataUsages/ with no guidance. This adds a clear hint: configure privacy in the web UI.

Test plan

TestClassify_PrivacyDataUsages — 3 subtests: appDataUsages path, appDataUsagesPublications, unrelated error passes through
ASC_BYPASS_KEYCHAIN=1 make test — all tests pass

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/739 **Author:** [@omar16100](https://github.com/omar16100) **Created:** 2/23/2026 **Status:** ✅ Merged **Merged:** 2/23/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feedback/privacy-error-hint` --- ### 📝 Commits (2) - [`cf61269`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cf61269733e3708c175249caa037f15c0b8c5a5f) feat(errfmt): add hint for app privacy/data usage errors - [`0d84f46`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0d84f461e807359ad1b2f233cfd84b4e421a2025) test(errfmt): prioritize privacy hint and tighten assertions ### 📊 Changes **2 files changed** (+79 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/shared/errfmt/errfmt.go` (+15 -0) 📝 `internal/cli/shared/errfmt/errfmt_test.go` (+64 -0) </details> ### 📄 Description ## Summary - Adds detection of `appDataUsages` / `appDataUsagesPublications` in API error messages within `errfmt.Classify()` - Surfaces actionable hint directing users to configure privacy declarations in App Store Connect web UI — the API does not expose these endpoints (confirmed against `docs/openapi/paths.txt`) - ~55 lines across `errfmt.go` + `errfmt_test.go` ## Motivation When `asc submit create` fails due to incomplete privacy declarations, the error references `/v1/appDataUsages/` with no guidance. This adds a clear hint: configure privacy in the web UI. ## Test plan - [x] `TestClassify_PrivacyDataUsages` — 3 subtests: appDataUsages path, appDataUsagesPublications, unrelated error passes through - [x] `ASC_BYPASS_KEYCHAIN=1 make test` — all tests pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>