[PR #702] [MERGED] Metadata file cleanup #723

New issue

Closed

opened 2026-02-26 22:32:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/702
Author: @cursor[bot]
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: feat/metadata-fastlane-parity-587 ← Head: cursor/metadata-file-cleanup-ce93

📝 Commits (1)

6cd624b metadata: disable HTML escaping and remove unused writer

📊 Changes

2 files changed (+47 additions, -13 deletions)

View changed files

📝 internal/cli/metadata/foundation.go (+12 -11)
📝 internal/cli/metadata/foundation_test.go (+35 -2)

📄 Description

Summary

Fixed HTML escaping in JSON encoding for App Store Connect localization files (AppInfoLocalization and VersionLocalization) to prevent unnecessary & character escaping and reduce noisy diffs.
Removed the unused and uncalled WriteAppInfoLocalizationFile function and its associated test.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/702 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/metadata-fastlane-parity-587` ← **Head:** `cursor/metadata-file-cleanup-ce93` --- ### 📝 Commits (1) - [`6cd624b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6cd624b85a5dc62605f8910a6ba2841f0d57465c) metadata: disable HTML escaping and remove unused writer ### 📊 Changes **2 files changed** (+47 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/metadata/foundation.go` (+12 -11) 📝 `internal/cli/metadata/foundation_test.go` (+35 -2) </details> ### 📄 Description ## Summary - Fixed HTML escaping in JSON encoding for App Store Connect localization files (`AppInfoLocalization` and `VersionLocalization`) to prevent unnecessary `&` character escaping and reduce noisy diffs. - Removed the unused and uncalled `WriteAppInfoLocalizationFile` function and its associated test. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>