[PR #709] [MERGED] feat(notify): add Slack thread_ts and release payload attachments #731

New issue

Closed

opened 2026-02-26 22:32:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/709
Author: @rudrankriyam
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/notify-slack-thread-release-payload

📝 Commits (5)

f8ce914 feat(notify): add Slack thread replies and release payload fields
7025470 fix(notify): support GovSlack webhook host and document Slack limits
05aad43 fix(notify): preserve payload numbers and enforce attachment flags
5828576 notify slack: avoid duplicate attachment message text
e20dacc Merge pull request #716 from rudrankriyam/cursor/slack-message-text-duplication-c6a7

📊 Changes

4 files changed (+565 additions, -11 deletions)

View changed files

📝 README.md (+15 -1)
📝 internal/cli/cmdtest/notify_test.go (+117 -0)
📝 internal/cli/notify/notify.go (+158 -9)
📝 internal/cli/notify/notify_test.go (+275 -1)

📄 Description

Summary

Add Slack thread reply support to asc notify slack via --thread-ts (maps to thread_ts) with format validation.
Add richer release-event payload support via --payload-json / --payload-file, rendered as deterministic Slack attachment fields with optional --pretext and --success color control.
Extend unit + cmd tests for valid/invalid paths and update README examples for thread replies and release payload usage.

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test
ASC_BYPASS_KEYCHAIN=1 go test ./internal/cli/notify ./internal/cli/cmdtest -run NotifySlack

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/709 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/notify-slack-thread-release-payload` --- ### 📝 Commits (5) - [`f8ce914`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f8ce914b32a6ea929ab66bf73a836de21f5bc235) feat(notify): add Slack thread replies and release payload fields - [`7025470`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7025470eb33a00276044f6332748849dd04134a9) fix(notify): support GovSlack webhook host and document Slack limits - [`05aad43`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/05aad43d7d6ebf4706151cb149b28eaf4a9b8832) fix(notify): preserve payload numbers and enforce attachment flags - [`5828576`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5828576ea5235af894d4a9f35f1317f4a6661cfe) notify slack: avoid duplicate attachment message text - [`e20dacc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e20dacc650d5201fb46e36ae8f3b16efa2a000c1) Merge pull request #716 from rudrankriyam/cursor/slack-message-text-duplication-c6a7 ### 📊 Changes **4 files changed** (+565 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+15 -1) 📝 `internal/cli/cmdtest/notify_test.go` (+117 -0) 📝 `internal/cli/notify/notify.go` (+158 -9) 📝 `internal/cli/notify/notify_test.go` (+275 -1) </details> ### 📄 Description ## Summary - Add Slack thread reply support to `asc notify slack` via `--thread-ts` (maps to `thread_ts`) with format validation. - Add richer release-event payload support via `--payload-json` / `--payload-file`, rendered as deterministic Slack attachment fields with optional `--pretext` and `--success` color control. - Extend unit + cmd tests for valid/invalid paths and update README examples for thread replies and release payload usage. ## Test plan - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` - [x] `ASC_BYPASS_KEYCHAIN=1 go test ./internal/cli/notify ./internal/cli/cmdtest -run NotifySlack` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>