[PR #681] [MERGED] Cli code refinements #709

New issue

Closed

opened 2026-02-26 22:32:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/681
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/account-insights-weekly ← Head: cursor/cli-code-refinements-e449

📝 Commits (1)

6f3f90c refactor shared section rendering and fix READY_FOR_REVIEW state symbol

📊 Changes

5 files changed (+64 additions, -94 deletions)

View changed files

📝 internal/cli/account/account.go (+2 -15)
📝 internal/cli/insights/insights.go (+4 -25)
📝 internal/cli/shared/shared.go (+23 -0)
📝 internal/cli/status/status.go (+34 -54)
📝 internal/cli/status/status_test.go (+1 -0)

📄 Description

Summary

Extracted duplicate orNA utility into internal/cli/shared for reuse across insights and status packages.
Refactored the triplicated renderSection closure into a shared helper function shared.RenderSection to be used by account, insights, and status packages.
Corrected stateSymbol logic in internal/cli/status to properly classify READY_FOR_REVIEW as an in-progress state ([~]) instead of a positive state ([+]).

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/681 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/account-insights-weekly` ← **Head:** `cursor/cli-code-refinements-e449` --- ### 📝 Commits (1) - [`6f3f90c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6f3f90c2ea8028e1c8308634dcf0d2912574272f) refactor shared section rendering and fix READY_FOR_REVIEW state symbol ### 📊 Changes **5 files changed** (+64 additions, -94 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/account/account.go` (+2 -15) 📝 `internal/cli/insights/insights.go` (+4 -25) 📝 `internal/cli/shared/shared.go` (+23 -0) 📝 `internal/cli/status/status.go` (+34 -54) 📝 `internal/cli/status/status_test.go` (+1 -0) </details> ### 📄 Description ## Summary - Extracted duplicate `orNA` utility into `internal/cli/shared` for reuse across `insights` and `status` packages. - Refactored the triplicated `renderSection` closure into a shared helper function `shared.RenderSection` to be used by `account`, `insights`, and `status` packages. - Corrected `stateSymbol` logic in `internal/cli/status` to properly classify `READY_FOR_REVIEW` as an in-progress state (`[~]`) instead of a positive state (`[+]`). ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>