[PR #679] [MERGED] Test helper duplication #708

New issue

Closed

opened 2026-02-26 22:32:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/679
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/account-insights-weekly ← Head: cursor/test-helper-duplication-7103

📝 Commits (1)

1bf053e cmdtest: reuse shared JSON response helper

📊 Changes

1 file changed (+1 additions, -5 deletions)

View changed files

📝 internal/cli/cmdtest/status_test.go (+1 -5)

📄 Description

Summary

Consolidated duplicate test helper statusJSONResponse into insightsJSONResponse to reduce code duplication and maintenance risk.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/679 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/account-insights-weekly` ← **Head:** `cursor/test-helper-duplication-7103` --- ### 📝 Commits (1) - [`1bf053e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1bf053ea0e19f829fdac4768c5959133024098ad) cmdtest: reuse shared JSON response helper ### 📊 Changes **1 file changed** (+1 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/status_test.go` (+1 -5) </details> ### 📄 Description ## Summary - Consolidated duplicate test helper `statusJSONResponse` into `insightsJSONResponse` to reduce code duplication and maintenance risk. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>