[PR #710] [MERGED] feat(product-pages): add CPP media upload and sync flows #729

New issue

Closed

opened 2026-02-26 22:32:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/710
Author: @rudrankriyam
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/cpp-media-upload-sync

📝 Commits (8)

8e4c65c feat(product-pages): add CPP media upload and sync flows
d37fdbb Reuse shared asset helpers for custom page media upload
22d1870 Merge pull request #715 from rudrankriyam/cursor/asset-helper-reuse-b464
fc308dc fix(product-pages): remove unused CPP media wrapper helpers
f1b3b24 refactor custom page media upload to reuse asset helpers
ed58092 Merge pull request #717 from rudrankriyam/cursor/custom-page-code-quality-3e1d
06d2e41 Fix custom page upload localization output and prune dead exports
4164f4c Merge pull request #718 from rudrankriyam/cursor/asset-helpers-localization-id-b4b1

📊 Changes

12 files changed (+905 additions, -30 deletions)

View changed files

📝 internal/asc/assets_output.go (+28 -0)
📝 internal/asc/client_assets.go (+58 -22)
📝 internal/asc/client_http_test.go (+112 -0)
📝 internal/asc/client_test.go (+110 -0)
📝 internal/asc/output_registry_init.go (+18 -0)
📝 internal/asc/output_test.go (+52 -0)
📝 internal/cli/assets/assets_helpers.go (+5 -0)
📝 internal/cli/assets/assets_previews.go (+10 -0)
📝 internal/cli/assets/assets_screenshots.go (+10 -0)
📝 internal/cli/cmdtest/product_pages_test.go (+128 -0)
📝 internal/cli/productpages/custom_page_localization_media_sets.go (+16 -8)
➕ internal/cli/productpages/custom_page_localization_media_upload.go (+358 -0)

📄 Description

Summary

add upload and sync subcommands for custom product page localization screenshot-sets and preview-sets, including validation, set creation, media upload, and delivery-state polling
add custom-product-page relationship support when creating appScreenshotSets and appPreviewSets (appCustomProductPageLocalization in request payloads)
add CLI and client tests for new command validation, request serialization, and HTTP request payload shape

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/710 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/cpp-media-upload-sync` --- ### 📝 Commits (8) - [`8e4c65c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8e4c65c632f7c12befb23ef7fb540113fcc52455) feat(product-pages): add CPP media upload and sync flows - [`d37fdbb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d37fdbbe05ac14274c502d472f0403d99d173e71) Reuse shared asset helpers for custom page media upload - [`22d1870`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/22d18707e557b806764a946fc247d47e659fadc7) Merge pull request #715 from rudrankriyam/cursor/asset-helper-reuse-b464 - [`fc308dc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/fc308dce93ea214c6f654106e37842f566c548c8) fix(product-pages): remove unused CPP media wrapper helpers - [`f1b3b24`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f1b3b241099dad28c19d1157cbf66552be6adf52) refactor custom page media upload to reuse asset helpers - [`ed58092`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ed5809296ea0107830b2b286df61c82ab29b80ce) Merge pull request #717 from rudrankriyam/cursor/custom-page-code-quality-3e1d - [`06d2e41`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/06d2e41df0cc67dfa19cd2f16b51070a57be8414) Fix custom page upload localization output and prune dead exports - [`4164f4c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4164f4c7e9ae9f80808b95b0bdb7727255bb56a5) Merge pull request #718 from rudrankriyam/cursor/asset-helpers-localization-id-b4b1 ### 📊 Changes **12 files changed** (+905 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/assets_output.go` (+28 -0) 📝 `internal/asc/client_assets.go` (+58 -22) 📝 `internal/asc/client_http_test.go` (+112 -0) 📝 `internal/asc/client_test.go` (+110 -0) 📝 `internal/asc/output_registry_init.go` (+18 -0) 📝 `internal/asc/output_test.go` (+52 -0) 📝 `internal/cli/assets/assets_helpers.go` (+5 -0) 📝 `internal/cli/assets/assets_previews.go` (+10 -0) 📝 `internal/cli/assets/assets_screenshots.go` (+10 -0) 📝 `internal/cli/cmdtest/product_pages_test.go` (+128 -0) 📝 `internal/cli/productpages/custom_page_localization_media_sets.go` (+16 -8) ➕ `internal/cli/productpages/custom_page_localization_media_upload.go` (+358 -0) </details> ### 📄 Description ## Summary - add `upload` and `sync` subcommands for custom product page localization `screenshot-sets` and `preview-sets`, including validation, set creation, media upload, and delivery-state polling - add custom-product-page relationship support when creating `appScreenshotSets` and `appPreviewSets` (`appCustomProductPageLocalization` in request payloads) - add CLI and client tests for new command validation, request serialization, and HTTP request payload shape ## Test plan - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>