[PR #680] [MERGED] wall: sort generated app entries alphabetically #710

New issue

Closed

opened 2026-02-26 22:32:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/680
Author: @rudrankriyam
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/wall-of-apps-alphabetical

📝 Commits (5)

1cc04e3 wall: sort generated app entries alphabetically
974fe5c wall: render icon wall and enrich App Store artwork
a32de8d wall: polish icon wall tile layout
9125fc7 Fix wall entry icon retention, shared sorting, and icon link escaping
4a862c6 Merge pull request #684 from rudrankriyam/cursor/wallgen-entry-generation-1367

📊 Changes

6 files changed (+731 additions, -83 deletions)

View changed files

📝 README.md (+105 -1)
📝 docs/wall-of-apps.json (+95 -71)
📝 internal/wallgen/wallgen.go (+145 -10)
📝 internal/wallgen/wallgen_test.go (+85 -0)
📝 tools/generate-app/main.go (+128 -1)
📝 tools/generate-app/main_test.go (+173 -0)

📄 Description

Summary

Sort docs/wall-of-apps.json entries by app name (case-insensitive, link as tie-breaker) whenever make generate app ... adds or updates an app.
Add a regression test in tools/generate-app that verifies JSON ordering after generation.
Apply the new behavior to the current Wall data so docs/wall-of-apps.json is already alphabetized for consumers pulling JSON directly.

Test plan

make generate app APP=\"Timefall\" LINK=\"https://apps.apple.com/app/id6757712804\" CREATOR=\"vatrueshka\" PLATFORM=\"iOS,macOS\"
make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

Made with Cursor

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/680 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/wall-of-apps-alphabetical` --- ### 📝 Commits (5) - [`1cc04e3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1cc04e379e1f09296b7056b42fdf3b9f0db45d7e) wall: sort generated app entries alphabetically - [`974fe5c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/974fe5c05f68fca632f9a28ec9a55905fffe88c0) wall: render icon wall and enrich App Store artwork - [`a32de8d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a32de8d57f21acafc62b954b53d6711ed7310243) wall: polish icon wall tile layout - [`9125fc7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9125fc7181228f601fe32712dc6fbca5534b3d38) Fix wall entry icon retention, shared sorting, and icon link escaping - [`4a862c6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4a862c6307b6323709f6c046ffe0be638d1866d5) Merge pull request #684 from rudrankriyam/cursor/wallgen-entry-generation-1367 ### 📊 Changes **6 files changed** (+731 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+105 -1) 📝 `docs/wall-of-apps.json` (+95 -71) 📝 `internal/wallgen/wallgen.go` (+145 -10) 📝 `internal/wallgen/wallgen_test.go` (+85 -0) 📝 `tools/generate-app/main.go` (+128 -1) 📝 `tools/generate-app/main_test.go` (+173 -0) </details> ### 📄 Description ## Summary - Sort `docs/wall-of-apps.json` entries by app name (case-insensitive, link as tie-breaker) whenever `make generate app ...` adds or updates an app. - Add a regression test in `tools/generate-app` that verifies JSON ordering after generation. - Apply the new behavior to the current Wall data so `docs/wall-of-apps.json` is already alphabetized for consumers pulling JSON directly. ## Test plan - [x] `make generate app APP=\"Timefall\" LINK=\"https://apps.apple.com/app/id6757712804\" CREATOR=\"vatrueshka\" PLATFORM=\"iOS,macOS\"` - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` Made with [Cursor](https://cursor.com) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>