[PR #614] [MERGED] Macos test path comparison #657

New issue

Closed

opened 2026-02-26 22:31:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/614
Author: @cursor[bot]
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: cursor/pr-612-review-4cbe ← Head: cursor/macos-test-path-comparison-c5a7

📝 Commits (1)

b65d683 cmdtest: fix path comparison in migrate import test

📊 Changes

1 file changed (+9 additions, -1 deletions)

View changed files

📝 internal/cli/cmdtest/migrate_import_test.go (+9 -1)

📄 Description

Summary

Fixes a test failure on macOS where path comparisons in migrate_import_test.go failed due to inconsistent symlink resolution between t.TempDir() and os.Getwd(). filepath.EvalSymlinks is now used to normalize paths for accurate comparison.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/614 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/pr-612-review-4cbe` ← **Head:** `cursor/macos-test-path-comparison-c5a7` --- ### 📝 Commits (1) - [`b65d683`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b65d683835bb495e339b0e057165a103d1e574fd) cmdtest: fix path comparison in migrate import test ### 📊 Changes **1 file changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/migrate_import_test.go` (+9 -1) </details> ### 📄 Description ## Summary - Fixes a test failure on macOS where path comparisons in `migrate_import_test.go` failed due to inconsistent symlink resolution between `t.TempDir()` and `os.Getwd()`. `filepath.EvalSymlinks` is now used to normalize paths for accurate comparison. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>