[PR #674] [MERGED] Duplicate localization validation #703

New issue

Closed

opened 2026-02-26 22:32:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/674
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/metadata-diff-586 ← Head: cursor/duplicate-localization-validation-f0ce

📝 Commits (1)

440c257 refactor diff localization key validation to shared helper

📊 Changes

2 files changed (+6 additions, -22 deletions)

View changed files

📝 internal/cli/diffcmd/localizations.go (+1 -22)
📝 internal/cli/shared/localizations.go (+5 -0)

📄 Description

Summary

Refactored localization validation to reuse existing shared helpers, eliminating duplicated logic in diffcmd.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/674 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/metadata-diff-586` ← **Head:** `cursor/duplicate-localization-validation-f0ce` --- ### 📝 Commits (1) - [`440c257`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/440c257ccfed1b89990d7296a2405396cb98f1a0) refactor diff localization key validation to shared helper ### 📊 Changes **2 files changed** (+6 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/diffcmd/localizations.go` (+1 -22) 📝 `internal/cli/shared/localizations.go` (+5 -0) </details> ### 📄 Description ## Summary - Refactored localization validation to reuse existing shared helpers, eliminating duplicated logic in `diffcmd`. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>