[PR #703] [MERGED] Metadata validation consistency #724

New issue

Closed

opened 2026-02-26 22:32:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/703
Author: @cursor[bot]
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: feat/metadata-fastlane-parity-587 ← Head: cursor/metadata-validation-consistency-9b23

📝 Commits (2)

4a1877f Fix metadata key casing parity and length check reuse
ae0affe test(metadata): add cmdtest fixture for case-insensitive keys

📊 Changes

5 files changed (+347 additions, -116 deletions)

View changed files

📝 internal/cli/cmdtest/metadata_push_test.go (+129 -0)
📝 internal/cli/metadata/push.go (+31 -11)
📝 internal/cli/metadata/push_test.go (+50 -0)
📝 internal/cli/metadata/validate.go (+18 -35)
📝 internal/validation/metadata.go (+119 -70)

📄 Description

Summary

Standardized JSON key casing handling across metadata validate and metadata push commands to be case-insensitive, preventing push failures for files that passed validation due to casing differences.
Refactored and consolidated metadata length validation logic in internal/cli/metadata/validate.go by introducing a shared helper function, eliminating duplication with internal/validation/metadata.go.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/703 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/metadata-fastlane-parity-587` ← **Head:** `cursor/metadata-validation-consistency-9b23` --- ### 📝 Commits (2) - [`4a1877f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4a1877f4d1e236faa89eecd3a6d00deb8d272e11) Fix metadata key casing parity and length check reuse - [`ae0affe`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ae0affed30f72513c4f65687b0e0f0d29c6164f3) test(metadata): add cmdtest fixture for case-insensitive keys ### 📊 Changes **5 files changed** (+347 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/metadata_push_test.go` (+129 -0) 📝 `internal/cli/metadata/push.go` (+31 -11) 📝 `internal/cli/metadata/push_test.go` (+50 -0) 📝 `internal/cli/metadata/validate.go` (+18 -35) 📝 `internal/validation/metadata.go` (+119 -70) </details> ### 📄 Description ## Summary - Standardized JSON key casing handling across `metadata validate` and `metadata push` commands to be case-insensitive, preventing push failures for files that passed validation due to casing differences. - Refactored and consolidated metadata length validation logic in `internal/cli/metadata/validate.go` by introducing a shared helper function, eliminating duplication with `internal/validation/metadata.go`. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>