[PR #643] [MERGED] fix(asc): validate relationship mutation inputs #674

New issue

Closed

opened 2026-02-26 22:32:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/643
Author: @rudrankriyam
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/relationship-mutation-validation

📝 Commits (1)

a46145f fix(asc): validate relationship mutation inputs

📊 Changes

6 files changed (+292 additions, -4 deletions)

View changed files

📝 internal/asc/client.go (+14 -0)
📝 internal/asc/client_builds.go (+18 -0)
📝 internal/asc/client_game_center_activities.go (+40 -4)
➕ internal/asc/client_relationship_mutations_validation_test.go (+198 -0)
📝 internal/asc/client_users.go (+18 -0)
📝 internal/asc/encryption.go (+4 -0)

📄 Description

What

Add input validation to relationship mutation helpers so they fail fast when required IDs/lists are missing (instead of issuing malformed requests).

Touched areas:

Build ↔ betaGroups relationship mutations
Beta group ↔ betaTesters relationship mutations
User ↔ visibleApps relationship mutations (+ relationship list validation)
Encryption declaration ↔ builds relationship mutation
Game Center activity ↔ achievements/leaderboards relationship mutations

Adds a regression test to ensure invalid inputs return errors without making any HTTP requests.

Why

Enterprise/CI usage benefits from predictable, local validation and avoids confusing server-side errors caused by empty path segments or empty linkage payloads.

Test Plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/643 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/relationship-mutation-validation` --- ### 📝 Commits (1) - [`a46145f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a46145fc5ed9471bfe4c5c378dca2368e84bd564) fix(asc): validate relationship mutation inputs ### 📊 Changes **6 files changed** (+292 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client.go` (+14 -0) 📝 `internal/asc/client_builds.go` (+18 -0) 📝 `internal/asc/client_game_center_activities.go` (+40 -4) ➕ `internal/asc/client_relationship_mutations_validation_test.go` (+198 -0) 📝 `internal/asc/client_users.go` (+18 -0) 📝 `internal/asc/encryption.go` (+4 -0) </details> ### 📄 Description ## What Add input validation to relationship mutation helpers so they fail fast when required IDs/lists are missing (instead of issuing malformed requests). Touched areas: - Build ↔ betaGroups relationship mutations - Beta group ↔ betaTesters relationship mutations - User ↔ visibleApps relationship mutations (+ relationship list validation) - Encryption declaration ↔ builds relationship mutation - Game Center activity ↔ achievements/leaderboards relationship mutations Adds a regression test to ensure invalid inputs return errors without making any HTTP requests. ## Why Enterprise/CI usage benefits from predictable, local validation and avoids confusing server-side errors caused by empty path segments or empty linkage payloads. ## Test Plan - `make format` - `make lint` - `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>