[PR #635] [MERGED] coverage: add missing Game Center detail/group relationships #668

New issue

Closed

opened 2026-02-26 22:32:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/635
Author: @rudrankriyam
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/issue-616-game-center-detail-group-relationships

📝 Commits (4)

a0ef5fd coverage: add missing Game Center detail/group relationships
ca7abad test: remove unused requireOrder field
d4a66a4 Fix Game Center challenges minimum platform version relationship type
72e7013 Merge pull request #639 from rudrankriyam/cursor/gamecenterdetail-relationship-type-d5af

📊 Changes

3 files changed (+705 additions, -0 deletions)

View changed files

➕ internal/asc/client_game_center_details_relationships.go (+194 -0)
➕ internal/asc/client_game_center_groups_relationships.go (+117 -0)
➕ internal/asc/client_http_issue_616_game_center_detail_group_relationships_test.go (+394 -0)

📄 Description

Summary

Implements the missing Game Center detail/group relationship endpoints listed in #616 and adds request-shaping tests.

Endpoints

GET /v1/gameCenterDetails/{id}/relationships/achievementReleases
GET /v1/gameCenterDetails/{id}/relationships/activityReleases
GET /v1/gameCenterDetails/{id}/relationships/challengeReleases
GET /v1/gameCenterDetails/{id}/relationships/gameCenterAchievements
GET /v1/gameCenterDetails/{id}/relationships/gameCenterAchievementsV2
GET /v1/gameCenterDetails/{id}/relationships/gameCenterActivities
GET /v1/gameCenterDetails/{id}/relationships/gameCenterAppVersions
GET /v1/gameCenterDetails/{id}/relationships/gameCenterChallenges
GET /v1/gameCenterDetails/{id}/relationships/gameCenterGroup
GET /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardSets
GET /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardSetsV2
GET /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboards
GET /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardsV2
GET /v1/gameCenterDetails/{id}/relationships/leaderboardReleases
GET /v1/gameCenterDetails/{id}/relationships/leaderboardSetReleases
GET /v1/gameCenterGroups/{id}/relationships/gameCenterAchievements
GET /v1/gameCenterGroups/{id}/relationships/gameCenterAchievementsV2
GET /v1/gameCenterGroups/{id}/relationships/gameCenterActivities
GET /v1/gameCenterGroups/{id}/relationships/gameCenterChallenges
GET /v1/gameCenterGroups/{id}/relationships/gameCenterDetails
GET /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardSets
GET /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardSetsV2
GET /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboards
GET /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardsV2
PATCH /v1/gameCenterDetails/{id}/relationships/challengesMinimumPlatformVersions
PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterAchievements
PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterAchievementsV2
PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardSets
PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardSetsV2
PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboards
PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardsV2
PATCH /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardSets
PATCH /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardSetsV2

Validation

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

Fixes #616

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/635 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/issue-616-game-center-detail-group-relationships` --- ### 📝 Commits (4) - [`a0ef5fd`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a0ef5fdb66d93f3437e8b797effb2accce6afb10) coverage: add missing Game Center detail/group relationships - [`ca7abad`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ca7abadea218979f98bd4a1f19c9ec7e6cb99f94) test: remove unused requireOrder field - [`d4a66a4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d4a66a492f18ac105d0bda6bd2a130be325624ec) Fix Game Center challenges minimum platform version relationship type - [`72e7013`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/72e7013b04b83e6cda68ad7b5e6eca234ccf8f26) Merge pull request #639 from rudrankriyam/cursor/gamecenterdetail-relationship-type-d5af ### 📊 Changes **3 files changed** (+705 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `internal/asc/client_game_center_details_relationships.go` (+194 -0) ➕ `internal/asc/client_game_center_groups_relationships.go` (+117 -0) ➕ `internal/asc/client_http_issue_616_game_center_detail_group_relationships_test.go` (+394 -0) </details> ### 📄 Description ## Summary Implements the missing Game Center detail/group relationship endpoints listed in #616 and adds request-shaping tests. ### Endpoints - GET /v1/gameCenterDetails/{id}/relationships/achievementReleases - GET /v1/gameCenterDetails/{id}/relationships/activityReleases - GET /v1/gameCenterDetails/{id}/relationships/challengeReleases - GET /v1/gameCenterDetails/{id}/relationships/gameCenterAchievements - GET /v1/gameCenterDetails/{id}/relationships/gameCenterAchievementsV2 - GET /v1/gameCenterDetails/{id}/relationships/gameCenterActivities - GET /v1/gameCenterDetails/{id}/relationships/gameCenterAppVersions - GET /v1/gameCenterDetails/{id}/relationships/gameCenterChallenges - GET /v1/gameCenterDetails/{id}/relationships/gameCenterGroup - GET /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardSets - GET /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardSetsV2 - GET /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboards - GET /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardsV2 - GET /v1/gameCenterDetails/{id}/relationships/leaderboardReleases - GET /v1/gameCenterDetails/{id}/relationships/leaderboardSetReleases - GET /v1/gameCenterGroups/{id}/relationships/gameCenterAchievements - GET /v1/gameCenterGroups/{id}/relationships/gameCenterAchievementsV2 - GET /v1/gameCenterGroups/{id}/relationships/gameCenterActivities - GET /v1/gameCenterGroups/{id}/relationships/gameCenterChallenges - GET /v1/gameCenterGroups/{id}/relationships/gameCenterDetails - GET /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardSets - GET /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardSetsV2 - GET /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboards - GET /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardsV2 - PATCH /v1/gameCenterDetails/{id}/relationships/challengesMinimumPlatformVersions - PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterAchievements - PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterAchievementsV2 - PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardSets - PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardSetsV2 - PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboards - PATCH /v1/gameCenterDetails/{id}/relationships/gameCenterLeaderboardsV2 - PATCH /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardSets - PATCH /v1/gameCenterGroups/{id}/relationships/gameCenterLeaderboardSetsV2 ## Validation - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` Fixes #616 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>