[PR #553] [MERGED] WallEntry struct duplication #616

New issue

Closed

opened 2026-02-26 22:31:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/553
Author: @cursor[bot]
Created: 2/15/2026
Status: ✅ Merged
Merged: 2/15/2026
Merged by: @rudrankriyam

Base: cursor/pr-551-generation-issue-69e0 ← Head: cursor/wallentry-struct-duplication-10fa

📝 Commits (1)

966d0d2 Share wall entry type between wallgen and generate-app

📊 Changes

2 files changed (+5 additions, -7 deletions)

View changed files

📝 internal/wallgen/wallgen.go (+4 -1)
📝 tools/generate-app/main.go (+1 -6)

📄 Description

Summary

Centralized the WallEntry struct in internal/wallgen to eliminate duplication and prevent silent data loss when tools/generate-app rewrites docs/wall-of-apps.json.
Moved and exported the containsFold helper to internal/wallgen for reuse.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

This PR modifies internal tooling and does not add or update a Wall app entry.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/553 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/15/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/pr-551-generation-issue-69e0` ← **Head:** `cursor/wallentry-struct-duplication-10fa` --- ### 📝 Commits (1) - [`966d0d2`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/966d0d253cdf3d30b8a6b1c4881d1ce199eb6875) Share wall entry type between wallgen and generate-app ### 📊 Changes **2 files changed** (+5 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `internal/wallgen/wallgen.go` (+4 -1) 📝 `tools/generate-app/main.go` (+1 -6) </details> ### 📄 Description ## Summary - Centralized the `WallEntry` struct in `internal/wallgen` to eliminate duplication and prevent silent data loss when `tools/generate-app` rewrites `docs/wall-of-apps.json`. - Moved and exported the `containsFold` helper to `internal/wallgen` for reuse. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) This PR modifies internal tooling and does not add or update a Wall app entry. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>