[PR #580] [MERGED] Force overwrite umask permissions #635

New issue

Closed

opened 2026-02-26 22:31:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/580
Author: @cursor[bot]
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/force-overwrite-umask-permissions-950c

📝 Commits (1)

cb5bfae Fix atomic overwrite respecting umask

📊 Changes

2 files changed (+68 additions, -5 deletions)

View changed files

📝 internal/cli/shared/atomic_write.go (+34 -5)
➕ internal/cli/shared/atomic_write_umask_test.go (+34 -0)

📄 Description

Summary

Fixes a security bug where forced file overwrites (--force) ignored the process umask, potentially leading to wider file permissions than intended. The fix ensures that the effective file permissions respect the caller's umask, consistent with non-forced writes.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/580 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/force-overwrite-umask-permissions-950c` --- ### 📝 Commits (1) - [`cb5bfae`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cb5bfaef5cc2f837e776fe33090a345723f3d4a0) Fix atomic overwrite respecting umask ### 📊 Changes **2 files changed** (+68 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/shared/atomic_write.go` (+34 -5) ➕ `internal/cli/shared/atomic_write_umask_test.go` (+34 -0) </details> ### 📄 Description ## Summary - Fixes a security bug where forced file overwrites (`--force`) ignored the process umask, potentially leading to wider file permissions than intended. The fix ensures that the effective file permissions respect the caller's umask, consistent with non-forced writes. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>