[PR #633] [MERGED] coverage: add missing Game Center leaderboard relationships #666

New issue

Closed

opened 2026-02-26 22:32:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/633
Author: @rudrankriyam
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/issue-617-game-center-leaderboards-relationships

📝 Commits (1)

df54ef4 coverage: add missing Game Center leaderboard relationships

📊 Changes

3 files changed (+852 additions, -0 deletions)

View changed files

➕ internal/asc/client_game_center_leaderboards_relationships.go (+300 -0)
➕ internal/asc/client_game_center_leaderboards_relationships_v2.go (+180 -0)
➕ internal/asc/client_http_issue_617_game_center_leaderboards_relationships_test.go (+372 -0)

📄 Description

Summary

Implements the missing Game Center leaderboard + leaderboard set relationship endpoints listed in #617 and adds request-shaping tests.

Endpoints

DELETE /v1/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards
DELETE /v2/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards
GET /v1/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards
GET /v1/gameCenterLeaderboardSets/{id}/relationships/groupLeaderboardSet
GET /v1/gameCenterLeaderboardSets/{id}/relationships/localizations
GET /v1/gameCenterLeaderboardSets/{id}/relationships/releases
GET /v1/gameCenterLeaderboards/{id}/relationships/groupLeaderboard
GET /v1/gameCenterLeaderboards/{id}/relationships/localizations
GET /v1/gameCenterLeaderboards/{id}/relationships/releases
GET /v2/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards
GET /v2/gameCenterLeaderboardSets/{id}/relationships/versions
GET /v2/gameCenterLeaderboards/{id}/relationships/versions
PATCH /v1/gameCenterLeaderboardSets/{id}/relationships/groupLeaderboardSet
PATCH /v1/gameCenterLeaderboards/{id}/relationships/activity
PATCH /v1/gameCenterLeaderboards/{id}/relationships/challenge
PATCH /v1/gameCenterLeaderboards/{id}/relationships/groupLeaderboard
PATCH /v2/gameCenterLeaderboards/{id}/relationships/activity
PATCH /v2/gameCenterLeaderboards/{id}/relationships/challenge
POST /v1/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards
POST /v2/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards

Validation

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

Fixes #617

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/633 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/issue-617-game-center-leaderboards-relationships` --- ### 📝 Commits (1) - [`df54ef4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/df54ef4212a7fdc68219b06a916c6175154128f7) coverage: add missing Game Center leaderboard relationships ### 📊 Changes **3 files changed** (+852 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `internal/asc/client_game_center_leaderboards_relationships.go` (+300 -0) ➕ `internal/asc/client_game_center_leaderboards_relationships_v2.go` (+180 -0) ➕ `internal/asc/client_http_issue_617_game_center_leaderboards_relationships_test.go` (+372 -0) </details> ### 📄 Description ## Summary Implements the missing Game Center leaderboard + leaderboard set relationship endpoints listed in #617 and adds request-shaping tests. ### Endpoints - DELETE /v1/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards - DELETE /v2/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards - GET /v1/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards - GET /v1/gameCenterLeaderboardSets/{id}/relationships/groupLeaderboardSet - GET /v1/gameCenterLeaderboardSets/{id}/relationships/localizations - GET /v1/gameCenterLeaderboardSets/{id}/relationships/releases - GET /v1/gameCenterLeaderboards/{id}/relationships/groupLeaderboard - GET /v1/gameCenterLeaderboards/{id}/relationships/localizations - GET /v1/gameCenterLeaderboards/{id}/relationships/releases - GET /v2/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards - GET /v2/gameCenterLeaderboardSets/{id}/relationships/versions - GET /v2/gameCenterLeaderboards/{id}/relationships/versions - PATCH /v1/gameCenterLeaderboardSets/{id}/relationships/groupLeaderboardSet - PATCH /v1/gameCenterLeaderboards/{id}/relationships/activity - PATCH /v1/gameCenterLeaderboards/{id}/relationships/challenge - PATCH /v1/gameCenterLeaderboards/{id}/relationships/groupLeaderboard - PATCH /v2/gameCenterLeaderboards/{id}/relationships/activity - PATCH /v2/gameCenterLeaderboards/{id}/relationships/challenge - POST /v1/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards - POST /v2/gameCenterLeaderboardSets/{id}/relationships/gameCenterLeaderboards ## Validation - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` Fixes #617 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>