[PR #666] [MERGED] Version date comparison logic #694

New issue

Closed

opened 2026-02-26 22:32:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/666
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/status-dashboard-full-585 ← Head: cursor/version-date-comparison-logic-448f

📝 Commits (1)

4e03255 Fix status date selection to parse RFC3339 timestamps

📊 Changes

2 files changed (+129 additions, -6 deletions)

View changed files

📝 internal/cli/status/status.go (+54 -6)
📝 internal/cli/status/status_test.go (+75 -0)

📄 Description

Summary

Refactored date parsing logic in selectLatestAppStoreVersion, selectLatestReviewSubmission, and selectLatestBetaReviewSubmission to use a shared, robust time.Parse utility. This addresses a potential bug where string-based date comparison could lead to incorrect ordering with varying date formats or timezone offsets, aligning the logic with existing robust implementations.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/666 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/status-dashboard-full-585` ← **Head:** `cursor/version-date-comparison-logic-448f` --- ### 📝 Commits (1) - [`4e03255`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4e03255688b89fca392ff3a3c1a494fe08ad65ee) Fix status date selection to parse RFC3339 timestamps ### 📊 Changes **2 files changed** (+129 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/status/status.go` (+54 -6) 📝 `internal/cli/status/status_test.go` (+75 -0) </details> ### 📄 Description ## Summary - Refactored date parsing logic in `selectLatestAppStoreVersion`, `selectLatestReviewSubmission`, and `selectLatestBetaReviewSubmission` to use a shared, robust `time.Parse` utility. This addresses a potential bug where string-based date comparison could lead to incorrect ordering with varying date formats or timezone offsets, aligning the logic with existing robust implementations. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>