[PR #577] [MERGED] Profile file system safety #633

New issue

Closed

opened 2026-02-26 22:31:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/577
Author: @cursor[bot]
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @rudrankriyam

Base: profiles/local-management ← Head: cursor/profile-file-system-safety-3825

📝 Commits (1)

7e8e896 Fix profiles local special-file scan and dedupe overwrite

📊 Changes

5 files changed (+174 additions, -159 deletions)

View changed files

📝 internal/cli/assets/assets_download_helpers.go (+1 -74)
📝 internal/cli/profiles/local.go (+18 -2)
📝 internal/cli/profiles/local_files.go (+2 -83)
➕ internal/cli/profiles/local_scan_unix_test.go (+60 -0)
➕ internal/cli/shared/atomic_write.go (+93 -0)

📄 Description

Summary

Prevented profiles local list/clean commands from hanging when encountering non-regular files (e.g., named pipes) in the install directory, improving CLI robustness.
Centralized the safe file overwrite logic into a new shared.AtomicWriteFile helper, removing duplicate implementations and reducing maintenance burden.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/577 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `profiles/local-management` ← **Head:** `cursor/profile-file-system-safety-3825` --- ### 📝 Commits (1) - [`7e8e896`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7e8e896e25fc49ea2b7e181ec83450ecb3353f31) Fix profiles local special-file scan and dedupe overwrite ### 📊 Changes **5 files changed** (+174 additions, -159 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/assets/assets_download_helpers.go` (+1 -74) 📝 `internal/cli/profiles/local.go` (+18 -2) 📝 `internal/cli/profiles/local_files.go` (+2 -83) ➕ `internal/cli/profiles/local_scan_unix_test.go` (+60 -0) ➕ `internal/cli/shared/atomic_write.go` (+93 -0) </details> ### 📄 Description ## Summary - Prevented `profiles local list`/`clean` commands from hanging when encountering non-regular files (e.g., named pipes) in the install directory, improving CLI robustness. - Centralized the safe file overwrite logic into a new `shared.AtomicWriteFile` helper, removing duplicate implementations and reducing maintenance burden. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>