[PR #632] [MERGED] coverage: add missing builds/TestFlight relationship endpoints #664

New issue

Closed

opened 2026-02-26 22:32:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/632
Author: @rudrankriyam
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/issue-621-builds-testflight-relationships

📝 Commits (1)

22400f0 coverage: add missing builds/TestFlight relationship endpoints

📊 Changes

9 files changed (+814 additions, -0 deletions)

View changed files

📝 internal/asc/client.go (+27 -0)
📝 internal/asc/client_beta_app_localizations.go (+27 -0)
📝 internal/asc/client_beta_feedback.go (+27 -0)
📝 internal/asc/client_build_bundles.go (+99 -0)
📝 internal/asc/client_build_relationships.go (+86 -0)
📝 internal/asc/client_builds.go (+35 -0)
➕ internal/asc/client_http_issue_621_builds_testflight_relationships_test.go (+292 -0)
📝 internal/asc/client_testflight_relationships.go (+140 -0)
📝 internal/asc/client_testflight_review.go (+81 -0)

📄 Description

Summary

Implements the missing builds/TestFlight relationship endpoints listed in #621 (GET + relationship mutations) and adds request-shaping tests.

Endpoints

DELETE /v1/betaGroups/{id}/relationships/builds
GET /v1/betaAppLocalizations/{id}/relationships/app
GET /v1/betaAppReviewDetails/{id}/relationships/app
GET /v1/betaAppReviewSubmissions/{id}/relationships/build
GET /v1/betaBuildLocalizations/{id}/relationships/build
GET /v1/betaFeedbackCrashSubmissions/{id}/relationships/crashLog
GET /v1/betaGroups/{id}/relationships/app
GET /v1/betaGroups/{id}/relationships/betaRecruitmentCriteria
GET /v1/betaGroups/{id}/relationships/betaRecruitmentCriterionCompatibleBuildCheck
GET /v1/buildBetaDetails/{id}/relationships/build
GET /v1/buildBundles/{id}/relationships/appClipDomainCacheStatus
GET /v1/buildBundles/{id}/relationships/appClipDomainDebugStatus
GET /v1/buildBundles/{id}/relationships/betaAppClipInvocations
GET /v1/buildBundles/{id}/relationships/buildBundleFileSizes
GET /v1/buildUploads/{id}/relationships/buildUploadFiles
GET /v1/builds/{id}/relationships/appEncryptionDeclaration
GET /v1/builds/{id}/relationships/betaAppReviewSubmission
PATCH /v1/builds/{id}/relationships/appEncryptionDeclaration
POST /v1/betaGroups/{id}/relationships/builds

Validation

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

Fixes #621

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/632 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/issue-621-builds-testflight-relationships` --- ### 📝 Commits (1) - [`22400f0`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/22400f032a1f90fdbd1b46cad5b303a0f39ab78a) coverage: add missing builds/TestFlight relationship endpoints ### 📊 Changes **9 files changed** (+814 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client.go` (+27 -0) 📝 `internal/asc/client_beta_app_localizations.go` (+27 -0) 📝 `internal/asc/client_beta_feedback.go` (+27 -0) 📝 `internal/asc/client_build_bundles.go` (+99 -0) 📝 `internal/asc/client_build_relationships.go` (+86 -0) 📝 `internal/asc/client_builds.go` (+35 -0) ➕ `internal/asc/client_http_issue_621_builds_testflight_relationships_test.go` (+292 -0) 📝 `internal/asc/client_testflight_relationships.go` (+140 -0) 📝 `internal/asc/client_testflight_review.go` (+81 -0) </details> ### 📄 Description ## Summary Implements the missing builds/TestFlight relationship endpoints listed in #621 (GET + relationship mutations) and adds request-shaping tests. ### Endpoints - DELETE /v1/betaGroups/{id}/relationships/builds - GET /v1/betaAppLocalizations/{id}/relationships/app - GET /v1/betaAppReviewDetails/{id}/relationships/app - GET /v1/betaAppReviewSubmissions/{id}/relationships/build - GET /v1/betaBuildLocalizations/{id}/relationships/build - GET /v1/betaFeedbackCrashSubmissions/{id}/relationships/crashLog - GET /v1/betaGroups/{id}/relationships/app - GET /v1/betaGroups/{id}/relationships/betaRecruitmentCriteria - GET /v1/betaGroups/{id}/relationships/betaRecruitmentCriterionCompatibleBuildCheck - GET /v1/buildBetaDetails/{id}/relationships/build - GET /v1/buildBundles/{id}/relationships/appClipDomainCacheStatus - GET /v1/buildBundles/{id}/relationships/appClipDomainDebugStatus - GET /v1/buildBundles/{id}/relationships/betaAppClipInvocations - GET /v1/buildBundles/{id}/relationships/buildBundleFileSizes - GET /v1/buildUploads/{id}/relationships/buildUploadFiles - GET /v1/builds/{id}/relationships/appEncryptionDeclaration - GET /v1/builds/{id}/relationships/betaAppReviewSubmission - PATCH /v1/builds/{id}/relationships/appEncryptionDeclaration - POST /v1/betaGroups/{id}/relationships/builds ## Validation - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` Fixes #621 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>