[PR #664] [MERGED] Positional fallback order #693

New issue

Closed

opened 2026-02-26 22:32:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/664
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/status-dashboard-full-585 ← Head: cursor/positional-fallback-order-603d

📝 Commits (1)

af3ee5f Fix ambiguous build beta detail fallback mapping

📊 Changes

2 files changed (+49 additions, -7 deletions)

View changed files

📝 internal/cli/status/status.go (+5 -7)
📝 internal/cli/status/status_test.go (+44 -0)

📄 Description

Summary

Refactored buildExternalStatesByBuildID to primarily map BuildBetaDetail to BuildID using explicit Relationships.Build.ID. A positional fallback is now only used as a last resort when no relationship data is present in any BuildBetaDetail response, addressing the potential for incorrect state assignments due to non-guaranteed API response ordering.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/664 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/status-dashboard-full-585` ← **Head:** `cursor/positional-fallback-order-603d` --- ### 📝 Commits (1) - [`af3ee5f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/af3ee5fee0a0b2f7c13aabaa0a5d8832389b9993) Fix ambiguous build beta detail fallback mapping ### 📊 Changes **2 files changed** (+49 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/status/status.go` (+5 -7) 📝 `internal/cli/status/status_test.go` (+44 -0) </details> ### 📄 Description ## Summary Refactored `buildExternalStatesByBuildID` to primarily map `BuildBetaDetail` to `BuildID` using explicit `Relationships.Build.ID`. A positional fallback is now only used as a last resort when no relationship data is present in any `BuildBetaDetail` response, addressing the potential for incorrect state assignments due to non-guaranteed API response ordering. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>