[PR #559] [MERGED] Category and screenshot validation #621

New issue

Closed

opened 2026-02-26 22:31:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/559
Author: @cursor[bot]
Created: 2/15/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @rudrankriyam

Base: validate/screenshot-presence ← Head: cursor/category-and-screenshot-validation-eea8

📝 Commits (1)

7556a33 Fix validate handling of null categories and screenshot locale fallback

📊 Changes

3 files changed (+46 additions, -14 deletions)

View changed files

📝 internal/asc/types/resources.go (+29 -1)
📝 internal/validation/screenshot_test.go (+8 -8)
📝 internal/validation/screenshots.go (+9 -5)

📄 Description

Summary

Fixed an issue where a missing primary category ({"data":null}) from the App Store Connect API would cause a parsing error instead of correctly reporting categories.primary_missing during validation. The Data field in AppInfoPrimaryCategoryRelationshipResponse is now a pointer to correctly handle null responses.
Corrected screenshot validation logic to align with App Store Connect's behavior, where only the primary localization requires screenshot sets. Other localizations can now omit their own screenshot sets and fall back to the primary language.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/559 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `validate/screenshot-presence` ← **Head:** `cursor/category-and-screenshot-validation-eea8` --- ### 📝 Commits (1) - [`7556a33`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7556a33d0ca334ec788542ef249cb875bfe997c5) Fix validate handling of null categories and screenshot locale fallback ### 📊 Changes **3 files changed** (+46 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/types/resources.go` (+29 -1) 📝 `internal/validation/screenshot_test.go` (+8 -8) 📝 `internal/validation/screenshots.go` (+9 -5) </details> ### 📄 Description ## Summary - Fixed an issue where a missing primary category (`{"data":null}`) from the App Store Connect API would cause a parsing error instead of correctly reporting `categories.primary_missing` during validation. The `Data` field in `AppInfoPrimaryCategoryRelationshipResponse` is now a pointer to correctly handle `null` responses. - Corrected screenshot validation logic to align with App Store Connect's behavior, where only the primary localization requires screenshot sets. Other localizations can now omit their own screenshot sets and fall back to the primary language. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>