[PR #535] [MERGED] Submit cancel id endpoint #599

New issue

Closed

opened 2026-02-26 22:31:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/535
Author: @rudrankriyam
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/submit-cancel-id-endpoint-2b2a

📝 Commits (1)

1dd67bc Fix submit cancel ID routing to reviewSubmissions

📊 Changes

3 files changed (+419 additions, -20 deletions)

View changed files

➕ internal/cli/cmdtest/submit_cancel_test.go (+186 -0)
📝 internal/cli/submit/submit.go (+34 -20)
📝 internal/cli/submit/submit_test.go (+199 -0)

📄 Description

Summary

Refactored submit cancel to correctly route --id to the modern CancelReviewSubmission endpoint.
Updated submit cancel --version-id to prioritize CancelReviewSubmission before falling back to legacy DeleteAppStoreVersionSubmission.
Improved error messages for clarity between modern review submissions and legacy app store version submissions.
Added new and extended existing tests for both submit package and cmdtest to cover these new behaviors and error paths.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/535 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/submit-cancel-id-endpoint-2b2a` --- ### 📝 Commits (1) - [`1dd67bc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1dd67bc134eb2b7289333e3f760c34b47f7db9c1) Fix submit cancel ID routing to reviewSubmissions ### 📊 Changes **3 files changed** (+419 additions, -20 deletions) <details> <summary>View changed files</summary> ➕ `internal/cli/cmdtest/submit_cancel_test.go` (+186 -0) 📝 `internal/cli/submit/submit.go` (+34 -20) 📝 `internal/cli/submit/submit_test.go` (+199 -0) </details> ### 📄 Description ## Summary - Refactored `submit cancel` to correctly route `--id` to the modern `CancelReviewSubmission` endpoint. - Updated `submit cancel --version-id` to prioritize `CancelReviewSubmission` before falling back to legacy `DeleteAppStoreVersionSubmission`. - Improved error messages for clarity between modern review submissions and legacy app store version submissions. - Added new and extended existing tests for both `submit` package and `cmdtest` to cover these new behaviors and error paths. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- <p><a href="https://cursor.com/background-agent?bcId=bc-cd2f33b5-d863-4c83-8f75-f9f5718661af"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-cd2f33b5-d863-4c83-8f75-f9f5718661af"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>