[PR #570] [MERGED] Certificates: add CSR generation command #625

New issue

Closed

opened 2026-02-26 22:31:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/570
Author: @rudrankriyam
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @rudrankriyam

Base: main ← Head: certificates/csr-generate

📝 Commits (5)

c35e7e8 feat(certificates): add CSR generation command
8c5be6e shared: dedupe safe file write logic
4c022c6 Merge pull request #572 from rudrankriyam/cursor/shared-safe-write-utility-eab2
e317b1e certificates csr: precheck outputs to avoid orphaned key
b6ae8ac Merge pull request #578 from rudrankriyam/cursor/certificates-key-file-orphan-009e

📊 Changes

5 files changed (+692 additions, -98 deletions)

View changed files

📝 internal/cli/assets/assets_download_helpers.go (+10 -98)
📝 internal/cli/certificates/certificates.go (+1 -0)
➕ internal/cli/certificates/csr.go (+267 -0)
➕ internal/cli/cmdtest/certificates_csr_generate_test.go (+303 -0)
➕ internal/cli/shared/safe_write.go (+111 -0)

📄 Description

Summary

Add asc certificates csr generate to generate an RSA private key + CSR (PEM) for feeding into asc certificates create --csr ....
Safe file behavior: refuses symlinks, refuses overwrite by default, supports explicit --force.
JSON-first summary output (never prints key material).

Closes #564.

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/570 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `certificates/csr-generate` --- ### 📝 Commits (5) - [`c35e7e8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c35e7e89f41279ddbfde1ee8f07f4c6143674d48) feat(certificates): add CSR generation command - [`8c5be6e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8c5be6e765913bd7e6a5486aa8b71379c5990567) shared: dedupe safe file write logic - [`4c022c6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4c022c66e9bf4733abb3047597d1333184993f17) Merge pull request #572 from rudrankriyam/cursor/shared-safe-write-utility-eab2 - [`e317b1e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e317b1eb1adf5ca6c1ab7538b09780322f75a8ca) certificates csr: precheck outputs to avoid orphaned key - [`b6ae8ac`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b6ae8ac29d7669c2e9231b50d05e162ca1fed4f6) Merge pull request #578 from rudrankriyam/cursor/certificates-key-file-orphan-009e ### 📊 Changes **5 files changed** (+692 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/assets/assets_download_helpers.go` (+10 -98) 📝 `internal/cli/certificates/certificates.go` (+1 -0) ➕ `internal/cli/certificates/csr.go` (+267 -0) ➕ `internal/cli/cmdtest/certificates_csr_generate_test.go` (+303 -0) ➕ `internal/cli/shared/safe_write.go` (+111 -0) </details> ### 📄 Description ## Summary - Add `asc certificates csr generate` to generate an RSA private key + CSR (PEM) for feeding into `asc certificates create --csr ...`. - Safe file behavior: refuses symlinks, refuses overwrite by default, supports explicit `--force`. - JSON-first summary output (never prints key material). Closes #564. ## Test plan - `make format` - `make lint` - `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>