[PR #491] [CLOSED] Doctor migration code quality #564

New issue

Closed

opened 2026-02-26 22:31:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/491
Author: @cursor[bot]
Created: 2/11/2026
Status: ❌ Closed

Base: cursor/auth-doctor-migration-hints-eb8e ← Head: cursor/doctor-migration-code-quality-432a

📝 Commits (1)

bd83398 Fix migration hint signal processing

📊 Changes

1 file changed (+6 additions, -10 deletions)

View changed files

📝 internal/auth/doctor_migration.go (+6 -10)

📄 Description

Summary

Removed unused appfileKeys variable to improve code clarity.
Refactored buildSuggestedCommands to be called once and passed to buildMigrationChecks and buildMigrationHints, avoiding redundant computation.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/491 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/11/2026 **Status:** ❌ Closed **Base:** `cursor/auth-doctor-migration-hints-eb8e` ← **Head:** `cursor/doctor-migration-code-quality-432a` --- ### 📝 Commits (1) - [`bd83398`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/bd83398b8831f065e1f6b5e34fb5abcfb2fb5938) Fix migration hint signal processing ### 📊 Changes **1 file changed** (+6 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `internal/auth/doctor_migration.go` (+6 -10) </details> ### 📄 Description ## Summary - Removed unused `appfileKeys` variable to improve code clarity. - Refactored `buildSuggestedCommands` to be called once and passed to `buildMigrationChecks` and `buildMigrationHints`, avoiding redundant computation. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>