[PR #496] [MERGED] Migration screenshot logic #570

New issue

Closed

opened 2026-02-26 22:31:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/496
Author: @cursor[bot]
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/11/2026
Merged by: @rudrankriyam

Base: cursor/migrate-import-full-layout-b7cc ← Head: cursor/migration-screenshot-logic-ee8b

📝 Commits (4)

cd1cc10 Fix migrate screenshot inference
134ca47 fix: map 6.9-inch migrate screenshots to APP_IPHONE_67
935542a Fix iPhone 6.9" screenshot display type mapping
0dd04f7 Merge branch 'cursor/migrate-import-full-layout-b7cc' into cursor/migration-screenshot-logic-ee8b

📊 Changes

4 files changed (+27 additions, -22 deletions)

View changed files

📝 internal/cli/cmdtest/migrate_import_test.go (+2 -2)
📝 internal/cli/migrate/migrate.go (+1 -1)
📝 internal/cli/migrate/screenshots.go (+4 -5)
📝 internal/cli/migrate/screenshots_test.go (+20 -14)

📄 Description

Summary

Corrected screenshot display type inference from filename to ignore directory components, preventing false matches from path segments.
Ensured screenshot uploads respect the shared request context timeout, aligning with other upload operations.
Fixed incorrect dimension mapping for iPhone 6.7" (2796x1290) and added the missing mapping for iPhone 6.9" (2868x1320) display types.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/496 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/11/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/migrate-import-full-layout-b7cc` ← **Head:** `cursor/migration-screenshot-logic-ee8b` --- ### 📝 Commits (4) - [`cd1cc10`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cd1cc1047e5d49265d40a905a941c08fc06b4e47) Fix migrate screenshot inference - [`134ca47`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/134ca47242240a517afac78f84fd20bbbec9342d) fix: map 6.9-inch migrate screenshots to APP_IPHONE_67 - [`935542a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/935542a0973dddea38cbccbc766ea11ed1ac480b) Fix iPhone 6.9" screenshot display type mapping - [`0dd04f7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0dd04f76134818aebbc3159781a282c1287bcda7) Merge branch 'cursor/migrate-import-full-layout-b7cc' into cursor/migration-screenshot-logic-ee8b ### 📊 Changes **4 files changed** (+27 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/migrate_import_test.go` (+2 -2) 📝 `internal/cli/migrate/migrate.go` (+1 -1) 📝 `internal/cli/migrate/screenshots.go` (+4 -5) 📝 `internal/cli/migrate/screenshots_test.go` (+20 -14) </details> ### 📄 Description ## Summary - Corrected screenshot display type inference from filename to ignore directory components, preventing false matches from path segments. - Ensured screenshot uploads respect the shared request context timeout, aligning with other upload operations. - Fixed incorrect dimension mapping for iPhone 6.7" (2796x1290) and added the missing mapping for iPhone 6.9" (2868x1320) display types. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>