[PR #536] [MERGED] Non-Unix symlink protection #600

New issue

Closed

opened 2026-02-26 22:31:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/536
Author: @cursor[bot]
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/non-unix-symlink-protection-92f3

📝 Commits (3)

8e7819b Harden publish IPA handling against symlink paths
e8abf1f Reject symlink swaps after upload source open
6ea5b56 Merge remote-tracking branch 'origin/main' into cursor/non-unix-symlink-protection-92f3

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 internal/asc/upload.go (+5 -0)

📄 Description

Summary

Addresses a TOCTOU race condition on non-Unix platforms where os.Open could silently follow a symlink, bypassing intended symlink protection.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/536 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/non-unix-symlink-protection-92f3` --- ### 📝 Commits (3) - [`8e7819b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8e7819b0bec8c5f861d730a9effe53ff78077273) Harden publish IPA handling against symlink paths - [`e8abf1f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e8abf1f52085ef6fd47ac188508033c6e16952f4) Reject symlink swaps after upload source open - [`6ea5b56`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6ea5b56ff027cc8dbf65eb37dcd9dac9b8f75604) Merge remote-tracking branch 'origin/main' into cursor/non-unix-symlink-protection-92f3 ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/upload.go` (+5 -0) </details> ### 📄 Description ## Summary - Addresses a TOCTOU race condition on non-Unix platforms where `os.Open` could silently follow a symlink, bypassing intended symlink protection. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>