[PR #451] [MERGED] Replace tabwriter with tablewriter for bordered table output #536

New issue

Closed

opened 2026-02-26 22:31:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/451
Author: @rudrankriyam
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/8/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/tablewriter-bordered-tables

📝 Commits (1)

0969cdb feat: replace tabwriter with tablewriter for bordered table output

📊 Changes

66 files changed (+1943 additions, -1859 deletions)

View changed files

📝 go.mod (+13 -2)
📝 go.sum (+25 -0)
📝 internal/asc/actors_output.go (+6 -6)
📝 internal/asc/analytics_output.go (+55 -57)
📝 internal/asc/assets_output.go (+60 -59)
📝 internal/asc/build_bundles_output.go (+28 -28)
📝 internal/asc/categories_output.go (+5 -6)
📝 internal/asc/devices_output.go (+10 -10)
📝 internal/asc/eula_output.go (+9 -13)
📝 internal/asc/finance_output.go (+13 -13)
📝 internal/asc/iap_output.go (+93 -84)
📝 internal/asc/nominations_output.go (+10 -10)
📝 internal/asc/offer_codes_custom_output.go (+18 -16)
📝 internal/asc/offer_codes_output.go (+18 -18)
📝 internal/asc/output_accessibility.go (+15 -17)
📝 internal/asc/output_age_rating.go (+5 -5)
📝 internal/asc/output_alternative_distribution.go (+39 -35)
📝 internal/asc/output_android_ios_mapping.go (+10 -10)
📝 internal/asc/output_app_clips.go (+90 -86)
📝 internal/asc/output_app_events.go (+39 -36)

...and 46 more files

📄 Description

Summary

Replace all text/tabwriter usage with github.com/olekukonko/tablewriter for bordered Unicode table output
Add shared RenderTable helper in internal/asc/table_render.go that centralizes table styling
Migrate ~340 call sites across 66 files (all internal/asc/ output formatters + CLI-level custom printers)
Histogram in reviews ratings now renders as a bordered table with a Bar column

Before

ID           Name            Bundle ID                        SKU
6747745091   FoundationLab   com.rudrankriyam.foundationlab   FLab123

After

┌────────────┬───────────────┬────────────────────────────────┬──────────┐
│     ID     │     Name      │           Bundle ID            │   SKU    │
├────────────┼───────────────┼────────────────────────────────┼──────────┤
│ 6747745091 │ FoundationLab │ com.rudrankriyam.foundationlab │ FLab123  │
└────────────┴───────────────┴────────────────────────────────┴──────────┘

Test plan

make format passes
make lint passes
make test passes (all 7600+ tests)
Manual verification: asc apps list --output table
Manual verification: asc categories list --output table
Help rendering (DefaultUsageFunc) unchanged — still uses text/tabwriter

Closes #450

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/451 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/8/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/tablewriter-bordered-tables` --- ### 📝 Commits (1) - [`0969cdb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0969cdb1a2c51def0052787283a6c2aeaff858a8) feat: replace tabwriter with tablewriter for bordered table output ### 📊 Changes **66 files changed** (+1943 additions, -1859 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+13 -2) 📝 `go.sum` (+25 -0) 📝 `internal/asc/actors_output.go` (+6 -6) 📝 `internal/asc/analytics_output.go` (+55 -57) 📝 `internal/asc/assets_output.go` (+60 -59) 📝 `internal/asc/build_bundles_output.go` (+28 -28) 📝 `internal/asc/categories_output.go` (+5 -6) 📝 `internal/asc/devices_output.go` (+10 -10) 📝 `internal/asc/eula_output.go` (+9 -13) 📝 `internal/asc/finance_output.go` (+13 -13) 📝 `internal/asc/iap_output.go` (+93 -84) 📝 `internal/asc/nominations_output.go` (+10 -10) 📝 `internal/asc/offer_codes_custom_output.go` (+18 -16) 📝 `internal/asc/offer_codes_output.go` (+18 -18) 📝 `internal/asc/output_accessibility.go` (+15 -17) 📝 `internal/asc/output_age_rating.go` (+5 -5) 📝 `internal/asc/output_alternative_distribution.go` (+39 -35) 📝 `internal/asc/output_android_ios_mapping.go` (+10 -10) 📝 `internal/asc/output_app_clips.go` (+90 -86) 📝 `internal/asc/output_app_events.go` (+39 -36) _...and 46 more files_ </details> ### 📄 Description ## Summary - Replace all `text/tabwriter` usage with `github.com/olekukonko/tablewriter` for bordered Unicode table output - Add shared `RenderTable` helper in `internal/asc/table_render.go` that centralizes table styling - Migrate ~340 call sites across 66 files (all `internal/asc/` output formatters + CLI-level custom printers) - Histogram in `reviews ratings` now renders as a bordered table with a Bar column ## Before ``` ID Name Bundle ID SKU 6747745091 FoundationLab com.rudrankriyam.foundationlab FLab123 ``` ## After ``` ┌────────────┬───────────────┬────────────────────────────────┬──────────┐ │ ID │ Name │ Bundle ID │ SKU │ ├────────────┼───────────────┼────────────────────────────────┼──────────┤ │ 6747745091 │ FoundationLab │ com.rudrankriyam.foundationlab │ FLab123 │ └────────────┴───────────────┴────────────────────────────────┴──────────┘ ``` ## Test plan - [x] `make format` passes - [x] `make lint` passes - [x] `make test` passes (all 7600+ tests) - [x] Manual verification: `asc apps list --output table` - [x] Manual verification: `asc categories list --output table` - [x] Help rendering (`DefaultUsageFunc`) unchanged — still uses `text/tabwriter` Closes #450 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>