[PR #600] [MERGED] chore: remove dead cmd wrappers #646

New issue

Closed

opened 2026-02-26 22:31:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/600
Author: @rudrankriyam
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/17/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/remove-dead-cmd-wrappers

📝 Commits (1)

3304327 chore(cmd): remove dead shared wrappers

📊 Changes

5 files changed (+2 additions, -70 deletions)

View changed files

➖ cmd/errors.go (+0 -12)
📝 cmd/run.go (+2 -2)
📝 cmd/run_additional_test.go (+0 -26)
➖ cmd/shared.go (+0 -24)
📝 internal/cli/shared/shared.go (+0 -6)

📄 Description

Remove dead code in the cmd package.

Delete cmd/shared.go and cmd/errors.go (thin wrappers around internal/cli/shared)
Update cmd/run.go to call shared.CleanupTempPrivateKeys and check shared.ReportedError directly
Drop the TestCmdSharedWrappersAndReportedError test that only existed to exercise those wrappers
Remove unused deprecated internal/cli/shared.CleanupTempPrivateKey

Why

These wrappers were only used by a single test and were otherwise unused in the binary.
Keeps the public surface smaller and avoids redundant indirection.

Tests

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/600 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/17/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/remove-dead-cmd-wrappers` --- ### 📝 Commits (1) - [`3304327`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3304327a5f50e70f55a9a585180391f67d7cca3d) chore(cmd): remove dead shared wrappers ### 📊 Changes **5 files changed** (+2 additions, -70 deletions) <details> <summary>View changed files</summary> ➖ `cmd/errors.go` (+0 -12) 📝 `cmd/run.go` (+2 -2) 📝 `cmd/run_additional_test.go` (+0 -26) ➖ `cmd/shared.go` (+0 -24) 📝 `internal/cli/shared/shared.go` (+0 -6) </details> ### 📄 Description Remove dead code in the `cmd` package. - Delete `cmd/shared.go` and `cmd/errors.go` (thin wrappers around `internal/cli/shared`) - Update `cmd/run.go` to call `shared.CleanupTempPrivateKeys` and check `shared.ReportedError` directly - Drop the `TestCmdSharedWrappersAndReportedError` test that only existed to exercise those wrappers - Remove unused deprecated `internal/cli/shared.CleanupTempPrivateKey` Why - These wrappers were only used by a single test and were otherwise unused in the binary. - Keeps the public surface smaller and avoids redundant indirection. Tests - `make format` - `make lint` - `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>