[PR #533] [MERGED] Auth doctor asc profile #597

New issue

Closed

opened 2026-02-26 22:31:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/533
Author: @cursor[bot]
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/auth-doctor-asc-profile-ebba

📝 Commits (3)

6440c56 Redact auth env identifiers in status and doctor
223f154 auth doctor: show ASC_PROFILE value in env diagnostics
a4a9298 Merge remote-tracking branch 'origin/main' into cursor/auth-doctor-asc-profile-ebba

📊 Changes

2 files changed (+9 additions, -1 deletions)

View changed files

📝 internal/auth/doctor.go (+5 -1)
📝 internal/auth/doctor_test.go (+4 -0)

📄 Description

Summary

Reverted the redaction of ASC_PROFILE values in diagnostic output, as it is a non-sensitive profile name crucial for debugging, unlike ASC_KEY_ID and ASC_ISSUER_ID.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/533 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/auth-doctor-asc-profile-ebba` --- ### 📝 Commits (3) - [`6440c56`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6440c565d38e5ba564d7efc839e869df09469a83) Redact auth env identifiers in status and doctor - [`223f154`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/223f15457bafd5de2609e72d79b199608787f145) auth doctor: show ASC_PROFILE value in env diagnostics - [`a4a9298`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a4a9298e9a2b6c91839d42645dfca6dbe70e29bf) Merge remote-tracking branch 'origin/main' into cursor/auth-doctor-asc-profile-ebba ### 📊 Changes **2 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/auth/doctor.go` (+5 -1) 📝 `internal/auth/doctor_test.go` (+4 -0) </details> ### 📄 Description ## Summary - Reverted the redaction of `ASC_PROFILE` values in diagnostic output, as it is a non-sensitive profile name crucial for debugging, unlike `ASC_KEY_ID` and `ASC_ISSUER_ID`. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>