[PR #445] [MERGED] refactor(cli): remove shared wrapper re-exports #533

New issue

Closed

opened 2026-02-26 22:31:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/445
Author: @rudrankriyam
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/8/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/remove-shared-wrappers-443

📝 Commits (1)

083cbeb refactor(cli): remove shared wrapper re-exports

📊 Changes

293 files changed (+4942 additions, -6953 deletions)

View changed files

📝 internal/cli/accessibility/accessibility.go (+48 -47)
➖ internal/cli/accessibility/shared_wrappers.go (+0 -46)
📝 internal/cli/actors/actors.go (+14 -13)
➖ internal/cli/actors/shared_wrappers.go (+0 -34)
📝 internal/cli/agerating/age_rating.go (+14 -13)
➖ internal/cli/agerating/shared_wrappers.go (+0 -34)
📝 internal/cli/agreements/agreements.go (+9 -8)
➖ internal/cli/agreements/shared_wrappers.go (+0 -30)
📝 internal/cli/alternativedistribution/alternative_distribution.go (+2 -1)
📝 internal/cli/alternativedistribution/alternative_distribution_domains.go (+20 -19)
📝 internal/cli/alternativedistribution/alternative_distribution_keys.go (+26 -25)
📝 internal/cli/alternativedistribution/alternative_distribution_package_versions.go (+24 -23)
📝 internal/cli/alternativedistribution/alternative_distribution_packages.go (+22 -21)
➖ internal/cli/alternativedistribution/shared_wrappers.go (+0 -34)
📝 internal/cli/analytics/analytics.go (+2 -1)
📝 internal/cli/analytics/analytics_instances.go (+12 -11)
📝 internal/cli/analytics/analytics_reports.go (+12 -11)
📝 internal/cli/analytics/analytics_requests.go (+25 -25)
📝 internal/cli/analytics/analytics_sales.go (+4 -4)
📝 internal/cli/analytics/analytics_segments.go (+6 -5)

...and 80 more files

📄 Description

Summary

remove per-command shared wrapper re-exports and call shared helpers directly
delete all shared_wrappers.go files to reduce boilerplate
keep CLI behavior unchanged while centralizing helper usage

Test plan

make format
make lint
make test

Closes #443.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/445 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/8/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/remove-shared-wrappers-443` --- ### 📝 Commits (1) - [`083cbeb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/083cbeb8fadb5866a060aef69a20d11becf2afed) refactor(cli): remove shared wrapper re-exports ### 📊 Changes **293 files changed** (+4942 additions, -6953 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/accessibility/accessibility.go` (+48 -47) ➖ `internal/cli/accessibility/shared_wrappers.go` (+0 -46) 📝 `internal/cli/actors/actors.go` (+14 -13) ➖ `internal/cli/actors/shared_wrappers.go` (+0 -34) 📝 `internal/cli/agerating/age_rating.go` (+14 -13) ➖ `internal/cli/agerating/shared_wrappers.go` (+0 -34) 📝 `internal/cli/agreements/agreements.go` (+9 -8) ➖ `internal/cli/agreements/shared_wrappers.go` (+0 -30) 📝 `internal/cli/alternativedistribution/alternative_distribution.go` (+2 -1) 📝 `internal/cli/alternativedistribution/alternative_distribution_domains.go` (+20 -19) 📝 `internal/cli/alternativedistribution/alternative_distribution_keys.go` (+26 -25) 📝 `internal/cli/alternativedistribution/alternative_distribution_package_versions.go` (+24 -23) 📝 `internal/cli/alternativedistribution/alternative_distribution_packages.go` (+22 -21) ➖ `internal/cli/alternativedistribution/shared_wrappers.go` (+0 -34) 📝 `internal/cli/analytics/analytics.go` (+2 -1) 📝 `internal/cli/analytics/analytics_instances.go` (+12 -11) 📝 `internal/cli/analytics/analytics_reports.go` (+12 -11) 📝 `internal/cli/analytics/analytics_requests.go` (+25 -25) 📝 `internal/cli/analytics/analytics_sales.go` (+4 -4) 📝 `internal/cli/analytics/analytics_segments.go` (+6 -5) _...and 80 more files_ </details> ### 📄 Description ## Summary - remove per-command shared wrapper re-exports and call shared helpers directly - delete all `shared_wrappers.go` files to reduce boilerplate - keep CLI behavior unchanged while centralizing helper usage ## Test plan - [x] make format - [x] make lint - [x] make test Closes #443. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>