[PR #597] [CLOSED] Spinner pagination helper #642

New issue

Closed

opened 2026-02-26 22:31:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/597
Author: @cursor[bot]
Created: 2/17/2026
Status: ❌ Closed

Base: cursor/app-version-localizations-a60b ← Head: cursor/spinner-pagination-helper-30ef

📝 Commits (1)

8a2300b shared: add PaginateAllWithSpinner helper

📊 Changes

33 files changed (+118 additions, -318 deletions)

View changed files

📝 internal/cli/analytics/analytics_instances.go (+2 -6)
📝 internal/cli/analytics/analytics_reports.go (+2 -6)
📝 internal/cli/analytics/analytics_requests.go (+2 -6)
📝 internal/cli/apps/apps.go (+2 -6)
📝 internal/cli/builds/build_test_notes.go (+2 -6)
📝 internal/cli/builds/builds_commands.go (+2 -6)
📝 internal/cli/builds/builds_individual_testers.go (+2 -6)
📝 internal/cli/builds/builds_related.go (+2 -6)
📝 internal/cli/builds/builds_relationships.go (+2 -6)
📝 internal/cli/builds/builds_uploads.go (+4 -12)
📝 internal/cli/certificates/certificates.go (+2 -6)
📝 internal/cli/profiles/profiles.go (+2 -6)
📝 internal/cli/reviews/review_attachments.go (+2 -6)
📝 internal/cli/reviews/review_items.go (+2 -6)
📝 internal/cli/reviews/review_submissions.go (+6 -18)
📝 internal/cli/reviews/reviews.go (+2 -6)
📝 internal/cli/reviews/reviews_summarizations.go (+2 -6)
📝 internal/cli/shared/spinner.go (+12 -0)
📝 internal/cli/testflight/beta_groups.go (+4 -12)
📝 internal/cli/testflight/beta_groups_relationships.go (+2 -6)

...and 13 more files

📄 Description

Summary

Introduced a PaginateAllWithSpinner helper function in internal/cli/shared/spinner.go to encapsulate the common pattern of displaying a spinner during paginated API calls.
Refactored over 30 call sites across various CLI packages to utilize this new helper, significantly reducing boilerplate and improving code maintainability.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/597 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/17/2026 **Status:** ❌ Closed **Base:** `cursor/app-version-localizations-a60b` ← **Head:** `cursor/spinner-pagination-helper-30ef` --- ### 📝 Commits (1) - [`8a2300b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8a2300bd710566b496fe1a722a3568392b44eeeb) shared: add PaginateAllWithSpinner helper ### 📊 Changes **33 files changed** (+118 additions, -318 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/analytics/analytics_instances.go` (+2 -6) 📝 `internal/cli/analytics/analytics_reports.go` (+2 -6) 📝 `internal/cli/analytics/analytics_requests.go` (+2 -6) 📝 `internal/cli/apps/apps.go` (+2 -6) 📝 `internal/cli/builds/build_test_notes.go` (+2 -6) 📝 `internal/cli/builds/builds_commands.go` (+2 -6) 📝 `internal/cli/builds/builds_individual_testers.go` (+2 -6) 📝 `internal/cli/builds/builds_related.go` (+2 -6) 📝 `internal/cli/builds/builds_relationships.go` (+2 -6) 📝 `internal/cli/builds/builds_uploads.go` (+4 -12) 📝 `internal/cli/certificates/certificates.go` (+2 -6) 📝 `internal/cli/profiles/profiles.go` (+2 -6) 📝 `internal/cli/reviews/review_attachments.go` (+2 -6) 📝 `internal/cli/reviews/review_items.go` (+2 -6) 📝 `internal/cli/reviews/review_submissions.go` (+6 -18) 📝 `internal/cli/reviews/reviews.go` (+2 -6) 📝 `internal/cli/reviews/reviews_summarizations.go` (+2 -6) 📝 `internal/cli/shared/spinner.go` (+12 -0) 📝 `internal/cli/testflight/beta_groups.go` (+4 -12) 📝 `internal/cli/testflight/beta_groups_relationships.go` (+2 -6) _...and 13 more files_ </details> ### 📄 Description ## Summary - Introduced a `PaginateAllWithSpinner` helper function in `internal/cli/shared/spinner.go` to encapsulate the common pattern of displaying a spinner during paginated API calls. - Refactored over 30 call sites across various CLI packages to utilize this new helper, significantly reducing boilerplate and improving code maintainability. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>